The pbench-user-benchmark invocation of run_snafu seems to be incorrect

[portante]

The use of pbench-user-benchmark at line 59 of workloads/templates/workload-fio-script-cm.yml appears to be incorrect.

By definition of how pbench-user-benchmark works, when run_snafu returns, pbench-user-benchmark will stop execution and all collection of tool data, and the created /var/lib/pbench-agent/pbench-user-benchmark_${config}_${datestamp} directory it created will be buttoned up.

Later on line 79, when fiotest.sh is invoked, another pbench run directory will be created for that fio test.

Perhaps consider one of two changes:

1. Drop the use of pbench-user-benchmark at line 59, and just invoke run_snafu without it.
2. Drop the use of pbench-fio at line 105 and let "snafu" orchestrate the fio workload itself.

[jerrygb]

Thank you for filing this @portante.

Seems there are a few other pieces to fio workload that is failing.

For example, there is an error at the following line.

workloads/workloads/templates/workload-fio-script-cm.yml.j2

Line 102 in b800a7d

sed -i 's/\-o StrictHostKeyChecking=no/\-o StrictHostKeyChecking=no \-l default \-p 2022/g' /opt/pbench-agent/base

Mon Sep 28 16:03:35 UTC 2020 Pods for FIO I/O test created.
sed: couldn't open temporary file /opt/pbench-agent/sedN4W3bm: Permission denied
[error][2020-09-28T16:03:40.021683720] pbench-fio: package version is missing in config file

Seems that expectations around the folder structure for /opt/pbench-agent, context user, etc.

Similarly there are also issues around setup of SSH config,

workloads/workloads/templates/workload-fio-script-cm.yml.j2

Line 75 in b800a7d

chmod 0600 ~/.ssh/config