From 07dfe2aa865adf112de7976787e9b830cc26c046 Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Fri, 17 Mar 2017 09:13:48 -0700 Subject: [PATCH] *: Use "NACK" for rejection MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I'm fine with REJECT, but Aleksa suggested a switch to NACK [1] to match the Linux Kernel's usage [2,3]. Jon suggests it may mean “negative acknowledgement” [4]. I've updated both GOVERNANCE and the PullApprove config because it seems better to have consistent keywords (so maintainers don't have to remember which context-dependent string keyword should use). [1]: https://github.com/opencontainers/project-template/pull/29#discussion_r106581275 [2]: https://github.com/opencontainers/project-template/pull/29#discussion_r106627134 [3]: http://lkml.iu.edu/hypermail/linux/kernel/0706.0/0303.html [4]: https://github.com/opencontainers/project-template/pull/29#discussion_r106627685 Signed-off-by: W. Trevor King --- .pullapprove.yml | 2 +- GOVERNANCE.md | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index 24b9b25..3717542 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -9,7 +9,7 @@ group_defaults: approve_by_comment: enabled: true approve_regex: ^LGTM - reject_regex: ^Rejected + reject_regex: ^NACK reset_on_push: enabled: true author_approval: diff --git a/GOVERNANCE.md b/GOVERNANCE.md index f053e11..c60339f 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -12,7 +12,7 @@ A maintainer SHOULD propose a motion on the dev@opencontainers.org mailing list ## Voting -Voting on a proposed motion SHOULD happen on the dev@opencontainers.org mailing list (except [security issues](#security-issues)) with maintainers posting LGTM or REJECT. +Voting on a proposed motion SHOULD happen on the dev@opencontainers.org mailing list (except [security issues](#security-issues)) with maintainers posting LGTM or NACK. Maintainers MAY also explicitly not vote by posting ABSTAIN (which is useful to revert a previous vote). Maintainers MAY post multiple times (e.g. as they revise their position based on feeback), but only their final post counts in the tally. A proposed motion is adopted if two-thirds of votes cast, a quorum having voted, are in favor of the release. @@ -20,16 +20,16 @@ A proposed motion is adopted if two-thirds of votes cast, a quorum having voted, Voting SHOULD remain open for a week to collect feedback from the wider community and allow the maintainers to digest the proposed motion. Under exceptional conditions (e.g. non-major security fix releases) proposals which reach quorum with unanimous support MAY be adopted earlier. -A maintainer MAY choose to reply with REJECT. -A maintainer posting a REJECT MUST include a list of concerns or links to written documentation for those concerns (e.g. GitHub issues or mailing-list threads). +A maintainer MAY choose to reply with NACK. +A maintainer posting a NACK MUST include a list of concerns or links to written documentation for those concerns (e.g. GitHub issues or mailing-list threads). The maintainers SHOULD try to resolve the concerns and wait for the rejecting maintainer to change their opinion to LGTM. -However, a motion MAY be adopted with REJECTs, as outlined in the previous paragraphs. +However, a motion MAY be adopted with NACKs, as outlined in the previous paragraphs. ## Quorum A quorum is established when at least two-thirds of maintainers have voted. -For projects that are not specifications, a [motion to release](#release-approval) MAY be adopted if the tally is at least three LGTMs and no REJECTs, even if three votes does not meet the usual two-thirds quorum. +For projects that are not specifications, a [motion to release](#release-approval) MAY be adopted if the tally is at least three LGTMs and no NACKs, even if three votes does not meet the usual two-thirds quorum. ## Amendments @@ -53,7 +53,7 @@ For example: After voting closes, a maintainer SHOULD post a tally to the motion thread with a subject template like: -> [{project} {status}]: {motion description} (+{LGTMs} -{REJECTs} #{ABSTAINs}) +> [{project} {status}]: {motion description} (+{LGTMs} -{NACKs} #{ABSTAINs}) Where `{status}` is either `adopted` or `rejected`. For example: