From 2ce747adf753af2a7a29a64b9846aac1e0e39886 Mon Sep 17 00:00:00 2001 From: "Alex G. Wolff" <13754094+alexgwolff@users.noreply.github.com> Date: Mon, 2 Jun 2025 13:19:40 -0300 Subject: [PATCH 1/4] feat: add support for Node 22 --- .github/workflows/alpine.yml | 3 +-- .github/workflows/linux.yml | 14 ++++---------- .github/workflows/macos.yml | 4 +--- .github/workflows/windows.yml | 4 +--- README.md | 12 +----------- lib/extensions.js | 1 + 6 files changed, 9 insertions(+), 29 deletions(-) diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index 7aaf451dc..47a689d9d 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -15,10 +15,9 @@ jobs: fail-fast: false matrix: node: - - 16 - 18 - - 19 - 20 + - 22 steps: - name: Install Alpine build tools diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 3f8939cc1..5d2317aef 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -14,23 +14,18 @@ jobs: fail-fast: false matrix: include: - - node: 16 - gcc: "gcc-8" - gpp: "g++-8" - os: ubuntu-20.04 - node: 18 gcc: "gcc-8" gpp: "g++-8" os: ubuntu-20.04 - - node: 19 - gcc: "gcc-8" - gpp: "g++-8" - os: ubuntu-20.04 - node: 20 gcc: "gcc-10" gpp: "g++-10" os: ubuntu-22.04 - + - node: 22 + gcc: "gcc-12" + gpp: "g++-12" + os: ubuntu-24.04 steps: - uses: actions/checkout@v4 @@ -56,7 +51,6 @@ jobs: run: npm test - uses: actions/upload-artifact@v3 - if: github.repository_owner == 'sass' && github.event_name != 'pull_request' with: name: ${{ matrix.node }} path: vendor/ diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 056e1cf3b..5bb40e1cf 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -14,10 +14,9 @@ jobs: fail-fast: false matrix: node: - - 16 - 18 - - 19 - 20 + - 22 steps: - uses: actions/checkout@v4 @@ -36,7 +35,6 @@ jobs: run: npm test - uses: actions/upload-artifact@v3 - if: github.repository_owner == 'sass' && github.event_name != 'pull_request' with: name: ${{ matrix.node }} path: vendor/ diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 50528faec..7c98c3a36 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -14,10 +14,9 @@ jobs: fail-fast: false matrix: node: - - 16 - 18 - - 19 - 20 + - 22 architecture: - x64 @@ -41,7 +40,6 @@ jobs: run: npm test - uses: actions/upload-artifact@v3 - if: github.repository_owner == 'sass' && github.event_name != 'pull_request' with: name: ${{ matrix.node }}-${{ matrix.architecture }} path: | diff --git a/README.md b/README.md index a7b18a686..ab5b2eaa8 100644 --- a/README.md +++ b/README.md @@ -17,19 +17,9 @@ Below is a quick guide for minimum and maximum supported versions of node-sass: NodeJS | Supported node-sass version | Node Module --------|-----------------------------|------------ +Node 22 | 10.0+ | 127 Node 20 | 9.0+ | 115 -Node 19 | 8.0+ | 111 Node 18 | 8.0+ | 108 -Node 17 | 7.0+, <8.0 | 102 -Node 16 | 6.0+ | 93 -Node 15 | 5.0+, <7.0 | 88 -Node 14 | 4.14+, <9.0 | 83 -Node 13 | 4.13+, <5.0 | 79 -Node 12 | 4.12+, <8.0 | 72 -Node 11 | 4.10+, <5.0 | 67 -Node 10 | 4.9+, <6.0 | 64 -Node 8 | 4.5.3+, <5.0 | 57 -Node <8 | <5.0 | <57 diff --git a/lib/extensions.js b/lib/extensions.js index 24314b8bd..445552594 100644 --- a/lib/extensions.js +++ b/lib/extensions.js @@ -85,6 +85,7 @@ function getHumanNodeVersion(abi) { case 108: return 'Node.js 18.x'; case 111: return 'Node.js 19.x'; case 115: return 'Node.js 20.x'; + case 127: return 'Node.js 22.x'; default: return false; } } From 6bef09834a6c756a881db77c2cc6d9593692b936 Mon Sep 17 00:00:00 2001 From: "Alex G. Wolff" <13754094+alexgwolff@users.noreply.github.com> Date: Mon, 2 Jun 2025 14:58:10 -0300 Subject: [PATCH 2/4] chore: update version --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index cb533412b..17b233fca 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "node-sass", - "version": "9.0.0", + "version": "10.0.0", "libsass": "3.5.5", "description": "Wrapper around libsass", "license": "MIT", @@ -16,7 +16,7 @@ "url": "http://andrew.github.com" }, "engines": { - "node": ">=16" + "node": ">=16 <23" }, "main": "lib/index.js", "nodeSassConfig": { From fcf077d2910d85fe021ff1c5e3a95dea6bcd040c Mon Sep 17 00:00:00 2001 From: "Alex G. Wolff" <13754094+alexgwolff@users.noreply.github.com> Date: Mon, 2 Jun 2025 15:14:07 -0300 Subject: [PATCH 3/4] chore: update actions --- .github/workflows/alpine.yml | 2 +- .github/workflows/linux.yml | 2 +- .github/workflows/macos.yml | 2 +- .github/workflows/windows.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml index 47a689d9d..309bf19d4 100644 --- a/.github/workflows/alpine.yml +++ b/.github/workflows/alpine.yml @@ -33,7 +33,7 @@ jobs: - name: Run tests run: npm test - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 if: github.repository_owner == 'sass' && github.event_name != 'pull_request' with: name: ${{ matrix.node }} diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 5d2317aef..7c01567d1 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -50,7 +50,7 @@ jobs: - name: Run tests run: npm test - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: ${{ matrix.node }} path: vendor/ diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 5bb40e1cf..ef4bbf8c5 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -34,7 +34,7 @@ jobs: - name: Run tests run: npm test - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: ${{ matrix.node }} path: vendor/ diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 7c98c3a36..5d5c39d59 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -39,7 +39,7 @@ jobs: - name: Run tests run: npm test - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: ${{ matrix.node }}-${{ matrix.architecture }} path: | From 02c950fb3e31bc9327a181f82405ef04baac7e35 Mon Sep 17 00:00:00 2001 From: "Alex G. Wolff" <13754094+alexgwolff@users.noreply.github.com> Date: Mon, 2 Jun 2025 15:28:25 -0300 Subject: [PATCH 4/4] temp --- .github/workflows/linux.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index 7c01567d1..518b88f11 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -17,7 +17,7 @@ jobs: - node: 18 gcc: "gcc-8" gpp: "g++-8" - os: ubuntu-20.04 + os: ubuntu-22.04 - node: 20 gcc: "gcc-10" gpp: "g++-10"