Skip to content

Minor improvements#28

Merged
nickjj merged 1 commit intonickjj:mainfrom
kapitalisman:feature/minor-improvements
Jan 31, 2026
Merged

Minor improvements#28
nickjj merged 1 commit intonickjj:mainfrom
kapitalisman:feature/minor-improvements

Conversation

@kapitalisman
Copy link
Contributor

Some minor improvements:

  • The test:coverage command was measuring the coverage of the tests themselves.
  • Using a simple string comparison instead of strtobool.

@nickjj
Copy link
Owner

nickjj commented Jan 31, 2026

Hi,

Thanks, good catch with test coverage.

What do you think about splitting out the test coverage change into its own PR? I'm open to merging that.

I'm not sure if I'm ready to drop strtobool yet because in larger projects it's a handy function to have available. While your patch does the same thing logically, it's a bit lower level and not as convenient / flexible IMO.

@kapitalisman kapitalisman force-pushed the feature/minor-improvements branch from 30b63d9 to 8789877 Compare January 31, 2026 12:49
@kapitalisman
Copy link
Contributor Author

I removed the last commit, so now only the test coverage part remains

@nickjj nickjj merged commit a85e00c into nickjj:main Jan 31, 2026
1 check passed
@nickjj
Copy link
Owner

nickjj commented Jan 31, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments