External storage not supported

[AlvaroAguilera]

I don't know whether this is an issue in the workflow engine itself or in this particular workflow but I'm unable to run scripts on files stored on a SMB/CIFS network storage connected using the external storage option of NC (31.0.3).

None of the file paths passed to the script is available when the cron job is run.

[blizzz]

Actually, '%f' should be used with external storages.

[AlvaroAguilera]

The path I get with %f doesn't exist when an external storage is involved. I guess the drive isn't mounted at the time of execution.
Everything works file with local drives though.

[AlvaroAguilera]

Problem still present in 31.0.4.

[blizzz]

%f is resolved at script execution time:

workflow_script/lib/BackgroundJobs/Launcher.php

Lines 31 to 35 in 21552a2

	if (strpos($command, '%f')) {
	$path = isset($argument['path']) ? (string)$argument['path'] : '';
	try {
	$view = new View(dirname($path));
	$tmpFile = $view->toTmpFile(basename($path));

Do you see any related warning in your log?

[AlvaroAguilera]

I don't get inside the IF clause:

$command = (string)$argument['command'];
error_log(print_r($argument, true));

Array
(
[command] => /data/bin/multiextract.sh '/data/tmp/oc_tmp_YIRYtiqxKDbhOdD4bKOGD8oo8b89VWdd.zip' '8266862' 'admin'
)

The %f is replaced somewhere before run().

[blizzz]

Hm… as a workaround, try to comment out this line in Operation.php:

workflow_script/lib/Operation.php

Line 189 in 21552a2

$command = str_replace('%f', escapeshellarg($fullPath), $command);

[AlvaroAguilera]

That doesn't change anything. The %f is still replaced before the run somewhere else.

[AlvaroAguilera]

It appears I'm not even entering Operation::buildCommand()

[blizzz]

The other place is in the background job as shown in #385 (comment)

There are no other places where it would be replaced.

[AlvaroAguilera]

I commented both of the lines, yet I still get a path on Launcher::run:

echo $wrapper:

sh -c '/data/bin/multiextract.sh '\''/data/tmp/oc_tmp_kDLk9DHuVQiBJWNzR3OeUO845Iydwm92.zip'\'' '\''8266862'\'' '\''admin'\''' >/dev/null &