-
Notifications
You must be signed in to change notification settings - Fork 35
Open
Description
Checklist
- I reviewed the Contributing Guide.
- I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.
Describe the bug
There are a few duplicate asserts and out-of-order UT_Set* functions that are run after the test function has already been called.
Code snips
CS/unit-test/cs_app_cmds_tests.c
Lines 378 to 380 in f958cc0
| UtAssert_True(CS_AppData.HkPacket.Payload.CmdCounter == 1, "CS_AppData.HkPacket.Payload.CmdCounter == 1"); | |
| UtAssert_True(CS_AppData.HkPacket.Payload.CmdCounter == 1, "CS_AppData.HkPacket.Payload.CmdCounter == 1"); |
CS/unit-test/cs_app_cmds_tests.c
Lines 490 to 494 in f958cc0
| /* Execute the function being tested */ | |
| CS_RecomputeBaselineAppCmd(&CmdPacket); | |
| UT_SetDeferredRetcode(UT_KEY(CS_GetAppResTblEntryByName), 1, true); | |
| UT_SetHandlerFunction(UT_KEY(CS_GetAppResTblEntryByName), CS_APP_CMDS_TEST_CS_GetAppResTblEntryByNameHandler1, | |
| NULL); |
Expected behavior
Correct tests.
Reporter Info
Avi Weiss @thnkslprpt
Metadata
Metadata
Assignees
Labels
No labels