Expired, Inactive, Cancelled domains Always give errors

[ludah2008]

TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /var/www/vhosts/xxxxxx.net/httpdocs/app/vendor/whmcs/whmcs-foundation/lib/Domain/Registrar/Domain.php:0
Stack trace:
#0 /var/www/vhosts/xxxxxxx.net/httpdocs/app/vendor/whmcs/whmcs-foundation/lib/Domain/Registrar/Domain.php(0): count()
#1 /var/www/vhosts/xxxxxxx.net/httpdocs/app/vendor/whmcs/whmcs-foundation/lib/Domains.php(0): WHMCS\Domain\Registrar\Domain->hasNameservers()
#2 /var/www/vhosts/xxxxxxxx.net/httpdocs/app/admin/clientsdomains.php(0): WHMCS\Domains->getDomainInformation()
#3 {main}

[tnewton1]

After encountering this issue myself multiple times, I got frustrated and ran the error and code through ChatGPT... it managed to get me a working fix. I have enough PHP knowledge to sanity check these fixes.

In function namesilo_transactionCall(...), before the last return $response, around line 305, put the following:

if (!is_array($values)) {
    return [];
}

This will make sure that an empty array rather than a null value is passed to GetNameservers().

The other change made is by updating function namesilo_GetNameservers($params) which was adjusted to:

function namesilo_GetNameservers($params)
{
    $apiServerUrl = ($params['Test_Mode'] == 'on') ? TEST_API_SERVER : LIVE_API_SERVER;
    $apiKey = ($params['Test_Mode'] == 'on') ? $params['Sandbox_API_Key'] : $params['Live_API_Key'];

    $domain = urlencode($params["sld"] . "." . $params["tld"]);
    $url = $apiServerUrl . "/api/getDomainInfo?version=1&type=xml&key={$apiKey}&domain={$domain}";

    $ch = curl_init();
    curl_setopt($ch, CURLOPT_URL, $url);
    curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
    $xmlResponse = curl_exec($ch);
    curl_close($ch);

    // Initialize with empty nameservers
    $nameservers = [
        'ns1' => '',
        'ns2' => '',
        'ns3' => '',
        'ns4' => '',
        'ns5' => ''
    ];

    if ($xmlResponse) {
        try {
            $xml = new SimpleXMLElement($xmlResponse);
            $i = 1;
            foreach ($xml->reply->nameservers->nameserver as $nsValue) {
                if ($i > 5) break;
                $nameservers["ns{$i}"] = (string)$nsValue;
                $i++;
            }
        } catch (Exception $e) {
            // Optional logging here
        }
    }

    return $nameservers;
}

EDIT: found a bug in this function and updated it so that now it properly gets the set nameservers.

With both of these in place, WHMCS finally quit yelling whenever I tried to deal with a cancelled, expired, etc. domain.

[ludah2008]

Its works @tnewton1, Thank you very much