From 0d2843ae876f3b083160c1d06d2173eff3976b8a Mon Sep 17 00:00:00 2001 From: Neem Serra Date: Mon, 26 Feb 2018 16:02:03 -0600 Subject: [PATCH 1/3] Add numberOfLines as a prop for the dropdown text --- src/components/dropdown/index.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/components/dropdown/index.js b/src/components/dropdown/index.js index fec18a0f..a3e41c13 100644 --- a/src/components/dropdown/index.js +++ b/src/components/dropdown/index.js @@ -66,6 +66,7 @@ export default class Dropdown extends PureComponent { textColor: 'rgba(0, 0, 0, .87)', itemColor: 'rgba(0, 0, 0, .54)', baseColor: 'rgba(0, 0, 0, .38)', + numberOfLines: 1, itemCount: 4, itemPadding: 8, @@ -131,6 +132,7 @@ export default class Dropdown extends PureComponent { itemColor: PropTypes.string, selectedItemColor: PropTypes.string, baseColor: PropTypes.string, + numberOfLines: PropTypes.number, itemTextStyle: Text.propTypes.style, @@ -385,9 +387,9 @@ export default class Dropdown extends PureComponent { } itemSize() { - let { fontSize, itemPadding } = this.props; + let { fontSize, itemPadding, numberOfLines } = this.props; - return Math.ceil(fontSize * 1.5 + itemPadding * 2); + return Math.ceil(fontSize * 1.5 * numberOfLines + itemPadding * 2); } visibleItemCount() { @@ -610,7 +612,7 @@ export default class Dropdown extends PureComponent { return ( - + {title} From 021b48b698ece0fc295c459501d43f73007d8c2e Mon Sep 17 00:00:00 2001 From: Mohamed Langi Date: Thu, 21 Jun 2018 12:11:42 -0500 Subject: [PATCH 2/3] changed style of disabled dropdown --- src/components/dropdown/index.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/dropdown/index.js b/src/components/dropdown/index.js index 241f299b..32dc283d 100644 --- a/src/components/dropdown/index.js +++ b/src/components/dropdown/index.js @@ -503,7 +503,8 @@ export default class Dropdown extends PureComponent { title = null == title || 'string' === typeof title? title: String(title); - + delete props.disabled; + const inputContainerStyle = this.props.disabled ? { borderBottomWidth: 0 } : {}; return ( ); } From adf9030872d419e8a717e0ec4f1522f2f28c4c4f Mon Sep 17 00:00:00 2001 From: Neem Serra Date: Mon, 2 Dec 2019 13:08:53 -0600 Subject: [PATCH 3/3] remove bottom border on text field in dropdown --- src/components/dropdown/index.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/dropdown/index.js b/src/components/dropdown/index.js index 4519ac44..064f3b6e 100644 --- a/src/components/dropdown/index.js +++ b/src/components/dropdown/index.js @@ -505,7 +505,6 @@ export default class Dropdown extends PureComponent { title: String(title); delete props.disabled; - const inputContainerStyle = this.props.disabled ? { borderBottomWidth: 0 } : {}; return ( ); }