Reduce the number of unpackaged/forked dependencies

[diox]

In requirements/prod_without_hash.txt we've got 10 or so dependencies that are pulled directly from github.

This sucks, slows down package creation/tests, etc. Let's try to reduce that to 0 by:

• Landing our forks patches upstream
• Using released packages
• Removing dependencies on weird or unmaintained code

TODO:

• django-queryset-transform (Moderated Reviews Count has been wrong for a long time #2963)
• django-tables (Set login stats when logging in through FxA #2578)
• happyforms (Please add dsb and hsb to AMO pages #2964)
• schematic (Delay on admin pages after updates #2863)
• jingo-minify
• django-moz-header (Remove package.json related code. #2984)
• nuggets (Stats page breaks for other languages #2965)
• django-session-csrf (Hovering over an incompatible add-on changes the size of description panel to other add-ons #2956)
• django-cache-machine
• django-uuidfield (gone in django 1.8 merge, see 7d2a98f)
• django-mobility Remove django-mobility and all code serving mobile-specific pages #4202

[andymckay]

django-uuidfield can probably be replaced with https://docs.djangoproject.com/en/1.9/ref/models/fields/#uuidfield anyway once we get to django 1.8.

[diox]

Yes, I wonder how straightforward the change will be though...

[EnTeQuAk]

Since we're using MySQL afair both use a similar way to store them so they are relatively compatible. It's a bit more complicated with postgres where django's uuidfield uses the builtin uuid field type.

[EnTeQuAk]

Regarding happyforms: #2462

[andymckay]

Found it interesting that django-moz-header isn't really a Python package at all, but a pile of jinja templates.

[EnTeQuAk]

And we don't use too much stuff from it.

src/olympia/lib/settings_base.py
412:    'moz_header',
490:            'moz_header/header.css',
491:            'moz_header/footer.css',
507:            'moz_header/header.css',
508:            'moz_header/footer.css',
679:            'moz_header/menu.js',

Binary file src/olympia/lib/settings_base.pyc matches.

src/olympia/templates/menu_links.html
1:{% extends "moz_header/menu_links.html" %}

src/olympia/templates/amo_footer.html
1:{% extends "moz_header/footer.html" %}

src/olympia/templates/copyright.html
1:{% extends 'moz_header/copyright.html' %}

But still, might some more grebbing and searching and trying...

[andymckay]

"more grebbing" 👍

[andymckay]

https://github.com/search?langOverride=&q=user%3Amozilla+django-moz-header&repo=&start_value=1&type=Code looks like almost no-one else uses it either. Just copy the stuff into src/olympia?

[diox]

Since we're using MySQL afair both use a similar way to store them so they are relatively compatible. It's a bit more complicated with postgres where django's uuidfield uses the builtin uuid field type.

I was more thinking about conversions from/to python. The fork of django-uuidfield we use has this code andymckay/django-uuidfield@029dd12 which is incompatible with the way upstream does things, so I'll bet we'll need to be extra careful when moving to the django's implementation.

[diox]

Regarding django-moz-header, one of the contractors working on AMO at the time opened mozilla/django-moz-header#20 but it never got merged, I assume because everyone is scared to modify this repos... I agree we should probably just copy it over.

[eviljeff]

shall we just merge django-mobility directly into olympia, stripping out anything unused?

[eviljeff]

btw, I filed #3058 for django-tables

[EnTeQuAk]

Started to push things upstream for cache-machine, django-cache-machine/django-cache-machine#120

[diox]

regarding django-moz-header:

https://github.com/search?langOverride=&q=user%3Amozilla+django-moz-header&repo=&start_value=1&type=Code looks like almost no-one else uses it either. Just copy the stuff into src/olympia?

Agreed, I'll do that.