API does not match Node

[bclinkinbeard]

According to http://nodejs.org/api/querystring.html, the returned object should have escape and unescape methods. Instead, it has encode and decode, with a different API, in that they return objects instead of strings.

[mike-spainhower]

Is this a dupe of the issue in the upstream project Gozala#6 ? This fork is specially made for https://github.com/substack/node-browserify and other projects that need es3 compatibility so any functionality and API issues should be opened with the upstream.

[bclinkinbeard]

Yea, I guess it is.

[dy]

Hello, guys @bclinkinbeard @mike-spainhower
We decided to get rid of jquery in our project, and we need node-jquery-param module to replace $.param.
Unfortunately, we've found that current browserify doesn't provide correct querystring module, particularly, it doesn't have .escape method, which results in errors.
It happens because of incompatibility of querystring-es3 API with node v0.10+ behavior.
That is really unfortunate.
Not sure where I have to place this issue, but I really hope on your aid.

[mike-spainhower]

Ok, since the maintainer of the upstream is being actively unhelpful, and browserify users (I am one also) seem to need this compatibility, I am willing to fully depart from the upstream and add this functionality in this repo.

@substack before I do this, would adding escape and unescape methods for node compat have any negative consequences for browserify, or is there any other consideration? Thanks.

[troggy]

What's the status of the issue? I'm stuck with using browserified request library which relies on a presence of unescape method

[SpainTrain]

Pinging @substack again on question above. I would not want to add this until @substack weighs in on any potential negative effects.

In the meantime, if anyone affected would like to open a PR for this, feel free.

[mathiasvr]

Hi, I extracted the querystring implementation from the node.js core at https://github.com/mathiasvr/querystring. It seems to work fine in browsers, passing the tests down to IE9. I could make a PR, but i guess we might as well wait and see what substack thinks 😉

[SpainTrain]

That's great @mathiasvr, thanks for the offer. Hopefully we can go that route.