Skip to content

possible packet_type bug in packet.py #216

@mattbanhamtektowr

Description

@mattbanhamtektowr

was just trying to get fxcm.py to connect via socket_io via engineio. Whilst debugging, I think I've found a bug in packet.py. The code reads:
.......
else:
self.packet_type = int(encoded_packet[0])

However, the valid socket_io message I got back from the fxcm server was 96:0{........}
In other words the OPEN packet type isn't the first character of encoded_packet but the character after the colon.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions