From 13f6c8193dde91709723970fd01ee27798876898 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Menneken?= Date: Thu, 28 Nov 2019 08:31:59 +0100 Subject: [PATCH] avoid unchecked casts in `AbstractGremlinResultReader#readProperty` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: André Menneken --- .../result/AbstractGremlinResultReader.java | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/main/java/com/microsoft/spring/data/gremlin/conversion/result/AbstractGremlinResultReader.java b/src/main/java/com/microsoft/spring/data/gremlin/conversion/result/AbstractGremlinResultReader.java index 1b7881b1..25657fa8 100644 --- a/src/main/java/com/microsoft/spring/data/gremlin/conversion/result/AbstractGremlinResultReader.java +++ b/src/main/java/com/microsoft/spring/data/gremlin/conversion/result/AbstractGremlinResultReader.java @@ -12,7 +12,7 @@ import org.springframework.util.Assert; import java.util.ArrayList; -import java.util.LinkedHashMap; +import java.util.List; import java.util.Map; @NoArgsConstructor @@ -22,20 +22,19 @@ public abstract class AbstractGremlinResultReader { /** * properties's organization is a little complicated. *

- * properties is LinkedHashMap + * properties is Map * K is String * V is ArrayList - * T is LinkedHashMap + * T is Map */ private Object readProperty(@NonNull Object value) { Assert.isInstanceOf(ArrayList.class, value, "should be instance of ArrayList"); - @SuppressWarnings("unchecked") final ArrayList> mapList - = (ArrayList>) value; + final List listValue = (List) value; + Assert.isTrue(listValue.size() == 1, "should be only 1 element in ArrayList"); + final Map map = (Map) listValue.get(0); - Assert.isTrue(mapList.size() == 1, "should be only 1 element in ArrayList"); - - return mapList.get(0).get(Constants.PROPERTY_VALUE); + return map.get(Constants.PROPERTY_VALUE); } protected void readResultProperties(@NonNull Map properties, @NonNull GremlinSource source) {