Development (#445)

* Update release notes to show support for GPT-5

* Documented support for gpt-image-1

* Update config.py

* remove documentation folder

* Documentation and message table support (#444)

* Develop demo docs and import markdown table support

* fixed enhanced citations for groups and public workspaces

* Updated to support showing public workspaces in scope

* Update config.py

* fix docs

* Updated RELEASE_NOTES

Author: paullizer

RELEASE_NOTES.md

@@ -1,6 +1,41 @@
 <!-- BEGIN RELEASE_NOTES.MD BLOCK -->
 # Feature Release
 
+### **(v0.229.014)**
+
+#### Bug Fixes
+
+##### Public Workspace Management Fixes
+
+*   **Public Workspace Management Permission Fix**
+    *   Fixed incorrect permission checking for public workspace management operations when "Require Membership to Create Public Workspaces" setting was enabled.
+    *   **Issue**: Users with legitimate access to manage workspaces (Owner/Admin/DocumentManager) were incorrectly shown "Forbidden" errors when accessing management functionality.
+    *   **Root Cause**: The `manage_public_workspace` route was incorrectly decorated with `@create_public_workspace_role_required`, conflating creation permissions with management permissions.
+    *   **Solution**: Removed the incorrect permission decorator from the management route, allowing workspace-specific membership roles to properly control access.
+    *   (Ref: `route_frontend_public_workspaces.py`, workspace permission logic)
+
+*   **Public Workspace Scope Display Enhancement**
+    *   Enhanced the Public Workspace scope selector in chat interface to show specific workspace names instead of generic "Public" label.
+    *   **Display Logic**: 
+        *   No visible workspaces: `"Public"`
+        *   1 visible workspace: `"Public: [Workspace Name]"`
+        *   2-3 visible workspaces: `"Public: [Name1], [Name2], [Name3]"`
+        *   More than 3 workspaces: `"Public: [Name1], [Name2], [Name3], 3+"`
+    *   **Benefits**: Improved workspace identification, consistent with Group scope naming pattern, better navigation between workspace scopes.
+    *   (Ref: `chat-documents.js`, scope label updates, dynamic workspace display)
+
+##### User Interface and Content Rendering Fixes
+
+*   **Unicode Table Rendering Fix**
+    *   Fixed issue where AI-generated tables using Unicode box-drawing characters were not rendering as proper HTML tables in the chat interface.
+    *   **Problem**: AI agents (particularly ESAM Agent) generated Unicode tables that appeared as plain text instead of formatted tables.
+    *   **Solution**: 
+        *   Added `convertUnicodeTableToMarkdown()` function to detect and convert Unicode table patterns to markdown format
+        *   Enhanced message processing pipeline to handle table preprocessing before markdown parsing
+        *   Improved `unwrapTablesFromCodeBlocks()` function to detect tables mistakenly wrapped in code blocks
+    *   **Impact**: Tables now render properly as HTML, improving readability and data presentation in chat responses.
+    *   (Ref: `chat-messages.js`, Unicode table conversion, markdown processing pipeline)
+
 ### **(v0.229.001)**
 
 #### New Features

application/single_app/config.py

@@ -88,7 +88,7 @@
 EXECUTOR_TYPE = 'thread'
 EXECUTOR_MAX_WORKERS = 30
 SESSION_TYPE = 'filesystem'
-VERSION = "0.229.002"
+VERSION = "0.229.014"
 SECRET_KEY = os.getenv('SECRET_KEY', 'dev-secret-key-change-in-production')
 
 CLIENTS = {}

application/single_app/route_enhanced_citations.py

@@ -12,6 +12,8 @@
 from functions_authentication import login_required, user_required, get_current_user_id
 from functions_settings import get_settings, enabled_required
 from functions_documents import get_document_metadata
+from functions_group import get_user_groups
+from functions_public_workspaces import get_user_visible_public_workspace_ids_from_settings
 from config import CLIENTS, storage_account_user_documents_container_name, storage_account_group_documents_container_name, storage_account_public_documents_container_name
 
 def register_enhanced_citations_routes(app):
@@ -172,10 +174,59 @@ def get_enhanced_citation_pdf():
 
 def get_document(user_id, doc_id):
     """
-    Get document metadata - using the existing function from functions_documents
+    Get document metadata - searches across all enabled workspace types
     """
     from functions_documents import get_document as backend_get_document
-    return backend_get_document(user_id, doc_id)
+    from functions_settings import get_settings
+    
+    settings = get_settings()
+    
+    # Try to get document from different workspace types based on what's enabled
+    # Start with personal workspace (most common)
+    if settings.get('enable_user_workspace', False):
+        try:
+            doc_response, status_code = backend_get_document(user_id, doc_id)
+            if status_code == 200:
+                return doc_response, status_code
+        except:
+            pass
+    
+    # Try group workspaces if enabled
+    if settings.get('enable_group_workspaces', False):
+        # We need to find which group this document belongs to
+        # This is more complex - we need to search across user's groups
+        try:
+            user_groups = get_user_groups(user_id)
+            for group in user_groups:
+                group_id = group.get('id')
+                if group_id:
+                    try:
+                        doc_response, status_code = backend_get_document(user_id, doc_id, group_id=group_id)
+                        if status_code == 200:
+                            return doc_response, status_code
+                    except:
+                        continue
+        except:
+            pass
+    
+    # Try public workspaces if enabled
+    if settings.get('enable_public_workspaces', False):
+        # We need to find which public workspace this document belongs to
+        # This requires checking user's accessible public workspaces
+        try:
+            accessible_workspace_ids = get_user_visible_public_workspace_ids_from_settings(user_id)
+            for workspace_id in accessible_workspace_ids:
+                try:
+                    doc_response, status_code = backend_get_document(user_id, doc_id, public_workspace_id=workspace_id)
+                    if status_code == 200:
+                        return doc_response, status_code
+                except:
+                    continue
+        except:
+            pass
+    
+    # If document not found in any workspace
+    return {"error": "Document not found or access denied"}, 404
 
 def determine_workspace_type_and_container(raw_doc):
     """
@@ -188,6 +239,17 @@ def determine_workspace_type_and_container(raw_doc):
     else:
         return 'personal', storage_account_user_documents_container_name
 
+def get_blob_name(raw_doc, workspace_type):
+    """
+    Determine the correct blob name based on workspace type
+    """
+    if workspace_type == 'public':
+        return f"{raw_doc['public_workspace_id']}/{raw_doc['file_name']}"
+    elif workspace_type == 'group':
+        return f"{raw_doc['group_id']}/{raw_doc['file_name']}"
+    else:
+        return f"{raw_doc['user_id']}/{raw_doc['file_name']}"
+
 def serve_enhanced_citation_content(raw_doc, content_type=None):
     """
     Server-side rendering: Serve enhanced citation file content directly
@@ -204,8 +266,8 @@ def serve_enhanced_citation_content(raw_doc, content_type=None):
     workspace_type, container_name = determine_workspace_type_and_container(raw_doc)
     container_client = blob_service_client.get_container_client(container_name)
 
-    # Build blob name
-    blob_name = f"{raw_doc['user_id']}/{raw_doc['file_name']}"
+    # Build blob name based on workspace type
+    blob_name = get_blob_name(raw_doc, workspace_type)
 
     try:
         # Download blob content directly
@@ -268,8 +330,8 @@ def serve_enhanced_citation_pdf_content(raw_doc, page_number):
     workspace_type, container_name = determine_workspace_type_and_container(raw_doc)
     container_client = blob_service_client.get_container_client(container_name)
 
-    # Build blob name
-    blob_name = f"{raw_doc['user_id']}/{raw_doc['file_name']}"
+    # Build blob name based on workspace type
+    blob_name = get_blob_name(raw_doc, workspace_type)
 
     try:
         # Download blob content directly

application/single_app/route_frontend_chats.py

@@ -165,7 +165,6 @@ def upload_file():
     @app.route("/view_pdf", methods=["GET"])
     @login_required
     @user_required
-    @enabled_required("enable_user_workspace")
     def view_pdf():
         """
         1) Grab 'doc_id' and 'page' from query params.
@@ -191,12 +190,28 @@ def view_pdf():
             return doc_response, status_code
 
         raw_doc = doc_response.get_json()
-        blob_name = f"{raw_doc['user_id']}/{raw_doc['file_name']}"
+        
+        # Determine workspace type and appropriate container
+        settings = get_settings()
+        if raw_doc.get('public_workspace_id'):
+            if not settings.get('enable_public_workspaces', False):
+                return jsonify({"error": "Public workspaces are not enabled"}), 403
+            container_name = storage_account_public_documents_container_name
+            blob_name = f"{raw_doc['public_workspace_id']}/{raw_doc['file_name']}"
+        elif raw_doc.get('group_id'):
+            if not settings.get('enable_group_workspaces', False):
+                return jsonify({"error": "Group workspaces are not enabled"}), 403
+            container_name = storage_account_group_documents_container_name
+            blob_name = f"{raw_doc['group_id']}/{raw_doc['file_name']}"
+        else:
+            if not settings.get('enable_user_workspace', False):
+                return jsonify({"error": "User workspaces are not enabled"}), 403
+            container_name = storage_account_user_documents_container_name
+            blob_name = f"{raw_doc['user_id']}/{raw_doc['file_name']}"
 
         # 3) Generate the SAS URL (short-lived, read-only)
-        settings = get_settings()
         blob_service_client = CLIENTS.get("storage_account_office_docs_client")
-        container_client = blob_service_client.get_container_client(storage_account_user_documents_container_name)
+        container_client = blob_service_client.get_container_client(container_name)
 
         sas_token = generate_blob_sas(
             account_name=blob_service_client.account_name,
@@ -304,7 +319,6 @@ def view_pdf():
     @app.route('/view_document')
     @login_required
     @user_required
-    @enabled_required("enable_user_workspace")
     def view_document():
         settings = get_settings()
         download_location = tempfile.gettempdir()
@@ -333,8 +347,22 @@ def view_document():
         if not file_name:
              return jsonify({"error": "Internal server error: Document metadata incomplete."}), 500
 
-        # Construct blob name using the owner's user_id from the document record
-        blob_name = f"{owner_user_id}/{file_name}"
+        # Determine workspace type and appropriate container
+        if raw_doc.get('public_workspace_id'):
+            if not settings.get('enable_public_workspaces', False):
+                return jsonify({"error": "Public workspaces are not enabled"}), 403
+            container_name = storage_account_public_documents_container_name
+            blob_name = f"{raw_doc['public_workspace_id']}/{file_name}"
+        elif raw_doc.get('group_id'):
+            if not settings.get('enable_group_workspaces', False):
+                return jsonify({"error": "Group workspaces are not enabled"}), 403
+            container_name = storage_account_group_documents_container_name
+            blob_name = f"{raw_doc['group_id']}/{file_name}"
+        else:
+            if not settings.get('enable_user_workspace', False):
+                return jsonify({"error": "User workspaces are not enabled"}), 403
+            container_name = storage_account_user_documents_container_name
+            blob_name = f"{owner_user_id}/{file_name}"
         file_ext = os.path.splitext(file_name)[-1].lower()
 
         # Ensure download location exists (good practice, especially if using mount)
@@ -349,7 +377,6 @@ def view_document():
             blob_service_client = CLIENTS.get("storage_account_office_docs_client")
             storage_account_key = settings.get("office_docs_key")
             storage_account_name = blob_service_client.account_name # Get from client
-            container_name = storage_account_user_documents_container_name # From config
 
             if not all([blob_service_client, storage_account_key, container_name]):
                 return jsonify({"error": "Internal server error: Storage access not configured."}), 500

application/single_app/route_frontend_public_workspaces.py

@@ -31,7 +31,6 @@ def my_public_workspaces():
     @login_required
     @user_required
     @enabled_required("enable_public_workspaces")
-    @create_public_workspace_role_required
     def manage_public_workspace(workspace_id):
         settings = get_settings()
         public_settings = sanitize_settings_for_user(settings)
@@ -98,4 +97,18 @@ def public_directory():
             'public_directory.html',
             settings=public_settings,
             app_settings=public_settings
-        )
+        )
+
+    @app.route('/set_active_public_workspace', methods=['POST'])
+    @login_required
+    @user_required
+    @enabled_required("enable_public_workspaces")
+    def set_active_public_workspace():
+        user_id = get_current_user_id()
+        workspace_id = request.form.get("workspace_id")
+        if not user_id or not workspace_id:
+            return "Missing user or workspace id", 400
+        success = update_user_settings(user_id, {"activePublicWorkspaceOid": workspace_id})
+        if not success:
+            return "Failed to update user settings", 500
+        return redirect(url_for('public_workspaces'))