From 56a612e8a9d0c9999998b125237798f10b29ba04 Mon Sep 17 00:00:00 2001 From: Bill Berry Date: Thu, 12 Feb 2026 19:01:30 -0800 Subject: [PATCH 1/2] fix(workflows): remove release-please skip guard that prevents tag creation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - remove commit-message guard from release-please job in main.yml - update docs/architecture/workflows.md to reflect v4 native handling - remove stale '(skipped on release commits)' note from jobs table Fixes #510 🐛 - Generated by Copilot --- .github/workflows/main.yml | 1 - docs/architecture/workflows.md | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8d2ca1bb..9f68278e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -64,7 +64,6 @@ jobs: release-please: name: Release Please - if: "${{ github.event_name != 'push' || !startsWith(github.event.head_commit.message, 'chore(main): release') }}" needs: - spell-check - markdown-lint diff --git a/docs/architecture/workflows.md b/docs/architecture/workflows.md index 81a7555b..261b722e 100644 --- a/docs/architecture/workflows.md +++ b/docs/architecture/workflows.md @@ -136,7 +136,7 @@ flowchart LR style RP fill:#f9f,stroke:#333 ``` -The release-please job includes a commit-message guard that skips execution when the head commit message starts with `chore(main): release`. This prevents an infinite loop where release-please-generated merge commits would re-trigger the release workflow. +Release-please v4 handles `chore` type commits natively — they are not releasable and do not produce spurious release PRs, so no commit-message guard is needed. ### Main Branch Jobs @@ -147,7 +147,7 @@ The release-please job includes a commit-message guard that skips execution when | table-format | Post-merge table validation | None | | dependency-pinning-scan | Security pinning check | None | | pester-tests | PowerShell unit tests | None | -| release-please | Automated release management | All validation jobs (skipped on release commits) | +| release-please | Automated release management | All validation jobs | | extension-package-release | Build release VSIX | release-please (conditional) | | attest-and-upload | Sign and upload VSIX | extension-package-release | From eacee0273ca70430f751d4d49f1659ed1dd89466 Mon Sep 17 00:00:00 2001 From: Bill Berry Date: Thu, 12 Feb 2026 21:26:58 -0800 Subject: [PATCH 2/2] fix(docs): address review comment and table formatting in workflows.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - replace em dash with period per writing-style guidance - hyphenate chore-type commits for grammar clarity - fix table column alignment to pass table-format check 🔧 - Generated by Copilot --- docs/architecture/workflows.md | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/architecture/workflows.md b/docs/architecture/workflows.md index 261b722e..d24d95a7 100644 --- a/docs/architecture/workflows.md +++ b/docs/architecture/workflows.md @@ -136,20 +136,20 @@ flowchart LR style RP fill:#f9f,stroke:#333 ``` -Release-please v4 handles `chore` type commits natively — they are not releasable and do not produce spurious release PRs, so no commit-message guard is needed. +Release-please v4 handles `chore`-type commits natively. They are not releasable and do not produce spurious release PRs, so no commit-message guard is needed. ### Main Branch Jobs -| Job | Purpose | Dependencies | -|---------------------------|--------------------------------|--------------------------------------------------| -| spell-check | Post-merge spelling validation | None | -| markdown-lint | Post-merge markdown validation | None | -| table-format | Post-merge table validation | None | -| dependency-pinning-scan | Security pinning check | None | -| pester-tests | PowerShell unit tests | None | -| release-please | Automated release management | All validation jobs | -| extension-package-release | Build release VSIX | release-please (conditional) | -| attest-and-upload | Sign and upload VSIX | extension-package-release | +| Job | Purpose | Dependencies | +|---------------------------|--------------------------------|------------------------------| +| spell-check | Post-merge spelling validation | None | +| markdown-lint | Post-merge markdown validation | None | +| table-format | Post-merge table validation | None | +| dependency-pinning-scan | Security pinning check | None | +| pester-tests | PowerShell unit tests | None | +| release-please | Automated release management | All validation jobs | +| extension-package-release | Build release VSIX | release-please (conditional) | +| attest-and-upload | Sign and upload VSIX | extension-package-release | When release-please creates a release, the `extension-package-release` job builds the VSIX with the correct version, and `attest-and-upload` signs it with Sigstore attestation before uploading to the GitHub Release.