diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 0d2ef58a..b683bb4b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -64,7 +64,6 @@ jobs: release-please: name: Release Please - if: "${{ github.event_name != 'push' || !startsWith(github.event.head_commit.message, 'chore(main): release') }}" needs: - spell-check - markdown-lint diff --git a/docs/architecture/workflows.md b/docs/architecture/workflows.md index 119211b4..625a4be5 100644 --- a/docs/architecture/workflows.md +++ b/docs/architecture/workflows.md @@ -136,20 +136,20 @@ flowchart LR style RP fill:#f9f,stroke:#333 ``` -The release-please job includes a commit-message guard that skips execution when the head commit message starts with `chore(main): release`. This prevents an infinite loop where release-please-generated merge commits would re-trigger the release workflow. +Release-please v4 handles `chore`-type commits natively. They are not releasable and do not produce spurious release PRs, so no commit-message guard is needed. ### Main Branch Jobs -| Job | Purpose | Dependencies | -|---------------------------|--------------------------------|--------------------------------------------------| -| spell-check | Post-merge spelling validation | None | -| markdown-lint | Post-merge markdown validation | None | -| table-format | Post-merge table validation | None | -| dependency-pinning-scan | Security pinning check | None | -| pester-tests | PowerShell unit tests | None | -| release-please | Automated release management | All validation jobs (skipped on release commits) | -| extension-package-release | Build release VSIX | release-please (conditional) | -| attest-and-upload | Sign and upload VSIX | extension-package-release | +| Job | Purpose | Dependencies | +|---------------------------|--------------------------------|------------------------------| +| spell-check | Post-merge spelling validation | None | +| markdown-lint | Post-merge markdown validation | None | +| table-format | Post-merge table validation | None | +| dependency-pinning-scan | Security pinning check | None | +| pester-tests | PowerShell unit tests | None | +| release-please | Automated release management | All validation jobs | +| extension-package-release | Build release VSIX | release-please (conditional) | +| attest-and-upload | Sign and upload VSIX | extension-package-release | When release-please creates a release, the `extension-package-release` job builds the VSIX with the correct version, and `attest-and-upload` signs it with Sigstore attestation before uploading to the GitHub Release.