-
Notifications
You must be signed in to change notification settings - Fork 34
Open
Labels
enhancementNew feature or requestNew feature or request
Description
If the TarExtractor fails to open the entry stream for an entry or to copy that to a new backing stream it catches the exception but continues parsing anyway. This likely doesn't make sense as if the stream is in an indeterminate state there's not much meaningful data there. This exception should clean up the now unused backing stream, and continue enumeration rather than continuing to try to parse this entry - or at least return a failed entry object (with an empty Content stream?). Should also check if this pattern exists in the other collectors.
RecursiveExtractor/RecursiveExtractor/Extractors/TarExtractor.cs
Lines 127 to 135 in a734749
| try | |
| { | |
| using Stream tarStream = tarEntry.OpenEntryStream(); | |
| tarStream.CopyTo(fs); | |
| } | |
| catch (Exception e) | |
| { | |
| Logger.Debug(Extractor.FAILED_PARSING_ERROR_MESSAGE_STRING, ArchiveFileType.TAR, fileEntry.FullPath, tarEntry.Key, e.GetType()); | |
| } |
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request