ctrl-c and ctrl-x don't work in command mode

[injust]

Description

ctrl-x used to work in command mode (both Cut and CutLine), but this regressed in a recent version.

ctrl-c doesn't work either, but that's an old bug and is tracked by #3784.

Environment

• Version: 2.0.15 (commit 6a62575)
• OS: macOS Sequoia
• Terminal: Ghostty

[Andriamanitra]

I git bisected the issue to this commit: a317aef

I think the issue is that InfoMapEvent does not do any of the handling of actions that use things like ,, &, |, command:, etc (like BufMapEvent would), so changing the binding to use Cut|CutLine instead of just Cut broke it.

micro/internal/action/infopane.go

Lines 24 to 33 in 3e95779

	func InfoMapEvent(k Event, action string) {
	config.Bindings["command"][k.Name()] = action
	switch e := k.(type) {
	case KeyEvent, KeySequenceEvent, RawEvent:
	infoMapKey(e, action)
	case MouseEvent:
	infoMapMouse(e, action)
	}
	}

micro/internal/action/bufpane.go

Lines 92 to 188 in 3e95779

	func BufMapEvent(k Event, action string) {
	config.Bindings["buffer"][k.Name()] = action
	var actionfns []BufAction
	var names []string
	var types []byte
	for i := 0; ; i++ {
	if action == "" {
	break
	}
	idx := util.IndexAnyUnquoted(action, "&|,")
	a := action
	if idx >= 0 {
	a = action[:idx]
	types = append(types, action[idx])
	action = action[idx+1:]
	} else {
	types = append(types, ' ')
	action = ""
	}
	var afn BufAction
	if strings.HasPrefix(a, "command:") {
	a = strings.SplitN(a, ":", 2)[1]
	afn = CommandAction(a)
	names = append(names, "")
	} else if strings.HasPrefix(a, "command-edit:") {
	a = strings.SplitN(a, ":", 2)[1]
	afn = CommandEditAction(a)
	names = append(names, "")
	} else if strings.HasPrefix(a, "lua:") {
	a = strings.SplitN(a, ":", 2)[1]
	afn = LuaAction(a, k)
	if afn == nil {
	screen.TermMessage("Lua Error:", a, "does not exist")
	continue
	}
	split := strings.SplitN(a, ".", 2)
	if len(split) > 1 {
	a = strings.Title(split[0]) + strings.Title(split[1])
	} else {
	a = strings.Title(a)
	}
	names = append(names, a)
	} else if f, ok := BufKeyActions[a]; ok {
	afn = f
	names = append(names, a)
	} else if f, ok := BufMouseActions[a]; ok {
	afn = f
	names = append(names, a)
	} else {
	screen.TermMessage("Error in bindings: action", a, "does not exist")
	continue
	}
	actionfns = append(actionfns, afn)
	}
	bufAction := func(h *BufPane, te *tcell.EventMouse) bool {
	for i, a := range actionfns {
	var success bool
	if _, ok := MultiActions[names[i]]; ok {
	success = true
	for _, c := range h.Buf.GetCursors() {
	h.Buf.SetCurCursor(c.Num)
	h.Cursor = c
	success = success && h.execAction(a, names[i], te)
	}
	} else {
	h.Buf.SetCurCursor(0)
	h.Cursor = h.Buf.GetActiveCursor()
	success = h.execAction(a, names[i], te)
	}
	// if the action changed the current pane, update the reference
	h = MainTab().CurPane()
	if h == nil {
	// stop, in case the current pane is not a BufPane
	break
	}
	if (!success && types[i] == '&') || (success && types[i] == '|') {
	break
	}
	}
	return true
	}
	switch e := k.(type) {
	case KeyEvent, KeySequenceEvent, RawEvent:
	BufBindings.RegisterKeyBinding(e, BufKeyActionGeneral(func(h *BufPane) bool {
	return bufAction(h, nil)
	}))
	case MouseEvent:
	BufBindings.RegisterMouseBinding(e, BufMouseActionGeneral(bufAction))
	}
	}

I'm not sure if there's a reason behind this or if it's just an oversight. Could all different kinds of buffers just use the same parsing logic for actions?

[dmaluka]

Yes, I think it's just an oversight or laziness. It should be possible to make chained actions work for all kinds of buffers, after some code refactoring.

In the meantime, we can fix this particular issue just by changing the default keybinding for Ctrl-x from Cut|CutLine back to Cut (for command mode only), and while we're at it, same for Ctrl-c: change it from Copy|CopyLine to Copy. Luckily, CutLine and CopyLine don't seem quite useful in command mode anyway.

I've uploaded #3973 for that.

Or also in the meantime the issue can be worked around, obviously, by changing them correspondingly to Cut and Copy in bindings.json:

    "command": {
        "Ctrl-c": "Copy",
        "Ctrl-x": "Cut"
    }

[injust]

@dmaluka Do you want to keep this issue open (or open a new one) to track supporting chained actions for command mode?

For example, I use chained actions for ctrl-c to do Copy,Deselect (see #3880).

[JoeKar]

@dmaluka Do you want to keep this issue open (or open a new one) to track supporting chained actions for command mode?

It was closed due to already linked PR.
We should open a new one for the tracking of it.
I'm unsure, if it is a bug or feature then.