Skip to content

Event pushes are basically broken/useless #28

@ferringb

Description

@ferringb

In looking at https://bugs.gentoo.org/965835 , I poked at this code a bit- in looking at it, added, removed, modified don't come through, and author is also broken.

with DEBUG forced, this is an example

ferringb@hrair ~/notify-webhook $ echo $(git rev-parse HEAD^^^^^^) $(git rev-parse HEAD) blah | ./notify-webhook.py > dump; jq -r < dump
/home/ferringb/notify-webhook/./notify-webhook.py:227: DeprecationWarning: 'count' is passed as positional argument
  props["message"] = re.sub(r"^(\t| {4})", "", sections[s + 1], 0, re.MULTILINE)
/home/ferringb/notify-webhook/./notify-webhook.py:227: DeprecationWarning: 'count' is passed as positional argument
  props["message"] = re.sub(r"^(\t| {4})", "", sections[s + 1], 0, re.MULTILINE)
/home/ferringb/notify-webhook/./notify-webhook.py:227: DeprecationWarning: 'count' is passed as positional argument
  props["message"] = re.sub(r"^(\t| {4})", "", sections[s + 1], 0, re.MULTILINE)
/home/ferringb/notify-webhook/./notify-webhook.py:227: DeprecationWarning: 'count' is passed as positional argument
  props["message"] = re.sub(r"^(\t| {4})", "", sections[s + 1], 0, re.MULTILINE)
/home/ferringb/notify-webhook/./notify-webhook.py:227: DeprecationWarning: 'count' is passed as positional argument
  props["message"] = re.sub(r"^(\t| {4})", "", sections[s + 1], 0, re.MULTILINE)
/home/ferringb/notify-webhook/./notify-webhook.py:227: DeprecationWarning: 'count' is passed as positional argument
  props["message"] = re.sub(r"^(\t| {4})", "", sections[s + 1], 0, re.MULTILINE)
/home/ferringb/notify-webhook/./notify-webhook.py:227: DeprecationWarning: 'count' is passed as positional argument
  props["message"] = re.sub(r"^(\t| {4})", "", sections[s + 1], 0, re.MULTILINE)
/home/ferringb/notify-webhook/./notify-webhook.py:227: DeprecationWarning: 'count' is passed as positional argument
  props["message"] = re.sub(r"^(\t| {4})", "", sections[s + 1], 0, re.MULTILINE)
/home/ferringb/notify-webhook/./notify-webhook.py:227: DeprecationWarning: 'count' is passed as positional argument
  props["message"] = re.sub(r"^(\t| {4})", "", sections[s + 1], 0, re.MULTILINE)
{
  "before": "136c7088c7f3d270c2b2047f90e6baad7eb550ce",
  "after": "4c5bb7462b9e595635ecdf450a38637e746a6b0a",
  "ref": "blah",
  "compare": null,
  "repository": {
    "url": null,
    "name": "notify-webhook",
    "description": "",
    "owner": {
      "name": "Jack Moffitt",
      "email": "jack@metajack.im"
    }
  },
  "commits": [
    {
      "id": "d193ce2e93c8467d7e4d2ea7f14a7eb161653fc0",
      "author": {
        "name": "",
        "email": "Robin H. Johnson"
      },
      "url": null,
      "message": "pylint: disable complexity issues for get_revisions function\n\nSigned-off-by: Robin H. Johnson <robbat2@gentoo.org>",
      "timestamp": "2019-12-17T23:02:30-0800",
      "added": [],
      "removed": [],
      "modified": []
    },
    {
      "id": "5c56e3d8d85253904369608355fbcc548f3a573c",
      "author": {
        "name": "",
        "email": "Robin H. Johnson"
      },
      "url": null,
      "message": "pylint: fix multiple-statements\n\nSigned-off-by: Robin H. Johnson <robbat2@gentoo.org>",
      "timestamp": "2019-12-17T23:03:26-0800",
      "added": [],
      "removed": [],
      "modified": []
    },
    {
      "id": "d1697272c7dff74c945f57e6e4a65e1306dd02f4",
      "author": {
        "name": "",
        "email": "Robin H. Johnson"
      },
      "url": null,
      "message": "Handle ref deletion\n\nIf a tag or branch deletion is pushed, a revision range is not\nmeaningful.\n\nFixes: https://github.com/metajack/notify-webhook/issues/18\nSigned-off-by: Robin H. Johnson <robbat2@gentoo.org>",
      "timestamp": "2019-12-17T23:13:12-0800",
      "added": [],
      "removed": [],
      "modified": []
    },
    {
      "id": "a659950d4f1264104ec1150cd79286edd8cffd0f",
      "author": {
        "name": "",
        "email": "Robin H. Johnson"
      },
      "url": null,
      "message": "autopep8: fixup whitespaces\n\nSigned-off-by: Robin H. Johnson <robbat2@gentoo.org>",
      "timestamp": "2019-12-17T23:18:43-0800",
      "added": [],
      "removed": [],
      "modified": []
    },
    {
      "id": "252250ab58c62f9f646066650fb3a7a8753a73a8",
      "author": {
        "name": "",
        "email": "Robin H. Johnson"
      },
      "url": null,
      "message": "pep8: more whitespace fixes\n\nSigned-off-by: Robin H. Johnson <robbat2@gentoo.org>",
      "timestamp": "2019-12-17T23:21:31-0800",
      "added": [],
      "removed": [],
      "modified": []
    },
    {
      "id": "3a352bf308d0294ed847544dfaa711c36ce7af64",
      "author": {
        "name": "",
        "email": "jmorsecode"
      },
      "url": null,
      "message": "swap out simplejson for standard json module",
      "timestamp": "2020-05-28T11:39:25-0400",
      "added": [],
      "removed": [],
      "modified": []
    },
    {
      "id": "8fde21a89920e51a7cdc16d629bd777067fc591d",
      "author": {
        "name": "",
        "email": "jmorsecode"
      },
      "url": null,
      "message": "Remove simplejson from deps and replace with Python3",
      "timestamp": "2020-05-29T08:27:17-0400",
      "added": [],
      "removed": [],
      "modified": []
    },
    {
      "id": "4c5bb7462b9e595635ecdf450a38637e746a6b0a",
      "author": {
        "name": "",
        "email": "Robin H. Johnson"
      },
      "url": null,
      "message": "Merge pull request #26 from jmorsecode/remove-simplejson\n\nRemove simplejson",
      "timestamp": "2021-04-23T14:30:44-0700",
      "added": [],
      "removed": [],
      "modified": []
    }
  ],
  "size": 8,
  "head_commit": {
    "id": "d193ce2e93c8467d7e4d2ea7f14a7eb161653fc0",
    "added": [],
    "removed": [],
    "modified": [],
    "date": "2019-12-17T23:02:30-0800",
    "message": "pylint: disable complexity issues for get_revisions function\n\nSigned-off-by: Robin H. Johnson <robbat2@gentoo.org>",
    "name": "",
    "email": "Robin H. Johnson"
  },
  "base_ref": "refs/heads/master"
}

Python 3.13.5, git 2.51.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions