From d2c6b1c2f075f1d103d206b2f08f7fab5007e936 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 2 Dec 2025 13:03:07 +0000 Subject: [PATCH 1/4] chore: Bump credo from 1.7.13 to 1.7.14 Bumps [credo](https://github.com/rrrene/credo) from 1.7.13 to 1.7.14. - [Release notes](https://github.com/rrrene/credo/releases) - [Changelog](https://github.com/rrrene/credo/blob/master/CHANGELOG.md) - [Commits](https://github.com/rrrene/credo/compare/v1.7.13...v1.7.14) --- updated-dependencies: - dependency-name: credo dependency-version: 1.7.14 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- mix.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mix.lock b/mix.lock index 077612b4..c65b4ac7 100644 --- a/mix.lock +++ b/mix.lock @@ -12,7 +12,7 @@ "comeonin": {:hex, :comeonin, "5.5.1", "5113e5f3800799787de08a6e0db307133850e635d34e9fab23c70b6501669510", [:mix], [], "hexpm", "65aac8f19938145377cee73973f192c5645873dcf550a8a6b18187d17c13ccdb"}, "connection": {:hex, :connection, "1.1.0", "ff2a49c4b75b6fb3e674bfc5536451607270aac754ffd1bdfe175abe4a6d7a68", [:mix], [], "hexpm", "722c1eb0a418fbe91ba7bd59a47e28008a189d47e37e0e7bb85585a016b2869c"}, "corsica": {:hex, :corsica, "2.1.3", "dccd094ffce38178acead9ae743180cdaffa388f35f0461ba1e8151d32e190e6", [:mix], [{:plug, "~> 1.0", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.0 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "616c08f61a345780c2cf662ff226816f04d8868e12054e68963e95285b5be8bc"}, - "credo": {:hex, :credo, "1.7.13", "126a0697df6b7b71cd18c81bc92335297839a806b6f62b61d417500d1070ff4e", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "47641e6d2bbff1e241e87695b29f617f1a8f912adea34296fb10ecc3d7e9e84f"}, + "credo": {:hex, :credo, "1.7.14", "c7e75216cea8d978ba8c60ed9dede4cc79a1c99a266c34b3600dd2c33b96bc92", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "12a97d6bb98c277e4fb1dff45aaf5c137287416009d214fb46e68147bd9e0203"}, "decimal": {:hex, :decimal, "2.3.0", "3ad6255aa77b4a3c4f818171b12d237500e63525c2fd056699967a3e7ea20f62", [:mix], [], "hexpm", "a4d66355cb29cb47c3cf30e71329e58361cfcb37c34235ef3bf1d7bf3773aeac"}, "dialyxir": {:hex, :dialyxir, "1.4.7", "dda948fcee52962e4b6c5b4b16b2d8fa7d50d8645bbae8b8685c3f9ecb7f5f4d", [:mix], [{:erlex, ">= 0.2.8", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "b34527202e6eb8cee198efec110996c25c5898f43a4094df157f8d28f27d9efe"}, "diskusage_logger": {:hex, :diskusage_logger, "0.2.0", "04fc48b538fe4de43153542a71ea94f623d54707d85844123baacfceedf625c3", [:mix], [], "hexpm", "e3f2aed1b0fc4590931c089a6453a4c4eb4c945912aa97bcabcc0cff7851f34d"}, From 6dd910944017e1c4e0534bcaf926993c6f4543a5 Mon Sep 17 00:00:00 2001 From: Eddie Maldonado Date: Tue, 2 Dec 2025 09:05:25 -0500 Subject: [PATCH 2/4] fix: fix credo errors --- apps/parse/lib/parse/alerts.ex | 6 +++--- .../test/state_mediator/integration/gtfs_test.exs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/parse/lib/parse/alerts.ex b/apps/parse/lib/parse/alerts.ex index 79d60d2b..8eed442d 100644 --- a/apps/parse/lib/parse/alerts.ex +++ b/apps/parse/lib/parse/alerts.ex @@ -157,9 +157,9 @@ defmodule Parse.Alerts do |> Enum.filter(&(&1["language"] == "en" or &1["language"] == nil)) |> Enum.sort(:desc) - case length(translations) >= 1 do - true -> hd(translations)["url"] - false -> default + case Enum.empty?(translations) do + false -> hd(translations)["url"] + true -> default end end diff --git a/apps/state_mediator/test/state_mediator/integration/gtfs_test.exs b/apps/state_mediator/test/state_mediator/integration/gtfs_test.exs index c8ee8b19..6d557e02 100644 --- a/apps/state_mediator/test/state_mediator/integration/gtfs_test.exs +++ b/apps/state_mediator/test/state_mediator/integration/gtfs_test.exs @@ -217,7 +217,7 @@ defmodule StateMediator.Integration.GtfsTest do ] end) - assert Enum.count(remaining_shapes) >= 1 + refute Enum.empty?(remaining_shapes) assert [%{name: "Wickford Junction - South Station"}, %{id: "9890003"}] = shapes_1 end From a8066288ba8eef0eb5f015c50b1167a656ce7ccd Mon Sep 17 00:00:00 2001 From: Eddie Maldonado Date: Fri, 16 Jan 2026 12:44:46 -0500 Subject: [PATCH 3/4] refactor: more readable `case` statement Co-authored-by: JD Rudie <46619169+rudiejd@users.noreply.github.com> --- apps/parse/lib/parse/alerts.ex | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/parse/lib/parse/alerts.ex b/apps/parse/lib/parse/alerts.ex index 8eed442d..a353f94f 100644 --- a/apps/parse/lib/parse/alerts.ex +++ b/apps/parse/lib/parse/alerts.ex @@ -157,7 +157,10 @@ defmodule Parse.Alerts do |> Enum.filter(&(&1["language"] == "en" or &1["language"] == nil)) |> Enum.sort(:desc) - case Enum.empty?(translations) do + case translations do + [] -> default + [first | _] -> first["url"] + end false -> hd(translations)["url"] true -> default end From 0845b77a04f47531116ca9ca6bbed67a5fb0b4f4 Mon Sep 17 00:00:00 2001 From: Eddie Maldonado Date: Fri, 16 Jan 2026 12:45:31 -0500 Subject: [PATCH 4/4] fixup! refactor: more readable `case` statement --- apps/parse/lib/parse/alerts.ex | 3 --- 1 file changed, 3 deletions(-) diff --git a/apps/parse/lib/parse/alerts.ex b/apps/parse/lib/parse/alerts.ex index a353f94f..47d053ca 100644 --- a/apps/parse/lib/parse/alerts.ex +++ b/apps/parse/lib/parse/alerts.ex @@ -161,9 +161,6 @@ defmodule Parse.Alerts do [] -> default [first | _] -> first["url"] end - false -> hd(translations)["url"] - true -> default - end end defp fallback_active_period([]) do