From 5c55f28ef68c97e5db890e5020b1449e56952c00 Mon Sep 17 00:00:00 2001 From: Mohit Padalia Date: Fri, 4 Jan 2019 11:45:32 +0530 Subject: [PATCH 1/4] Card type detection fixed --- SwiftLuhn/Classes/SwiftLuhn.swift | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/SwiftLuhn/Classes/SwiftLuhn.swift b/SwiftLuhn/Classes/SwiftLuhn.swift index 3495f8a..44c3471 100644 --- a/SwiftLuhn/Classes/SwiftLuhn.swift +++ b/SwiftLuhn/Classes/SwiftLuhn.swift @@ -19,6 +19,8 @@ open class SwiftLuhn { case maestro case rupay case mir + + static var count: Int { return CardType.mir.rawValue + 1 } } public enum CardError: Error { @@ -116,7 +118,7 @@ open class SwiftLuhn { class func cardType(for cardNumber: String, suggest: Bool = false) throws -> CardType { var foundCardType: CardType? - for i in CardType.amex.rawValue...CardType.jcb.rawValue { + for i in CardType.amex.rawValue.. Date: Fri, 4 Jan 2019 16:02:37 +0530 Subject: [PATCH 2/4] Changes to get list of all supported cardType --- SwiftLuhn/Classes/SwiftLuhn.swift | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/SwiftLuhn/Classes/SwiftLuhn.swift b/SwiftLuhn/Classes/SwiftLuhn.swift index 44c3471..23be076 100644 --- a/SwiftLuhn/Classes/SwiftLuhn.swift +++ b/SwiftLuhn/Classes/SwiftLuhn.swift @@ -20,7 +20,15 @@ open class SwiftLuhn { case rupay case mir - static var count: Int { return CardType.mir.rawValue + 1 } + static var allCards: [CardType] { + var values: [CardType] = [] + var index = 1 + while let element = self.init(rawValue: index) { + values.append(element) + index += 1 + } + return values + } } public enum CardError: Error { @@ -118,8 +126,7 @@ open class SwiftLuhn { class func cardType(for cardNumber: String, suggest: Bool = false) throws -> CardType { var foundCardType: CardType? - for i in CardType.amex.rawValue.. Date: Tue, 8 Jan 2019 13:06:31 +0530 Subject: [PATCH 3/4] Commit to trigger CircleCi --- SwiftLuhn/Classes/SwiftLuhn.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SwiftLuhn/Classes/SwiftLuhn.swift b/SwiftLuhn/Classes/SwiftLuhn.swift index 23be076..e643d4c 100644 --- a/SwiftLuhn/Classes/SwiftLuhn.swift +++ b/SwiftLuhn/Classes/SwiftLuhn.swift @@ -24,7 +24,7 @@ open class SwiftLuhn { var values: [CardType] = [] var index = 1 while let element = self.init(rawValue: index) { - values.append(element) + values.append(element); index += 1 } return values From 05455b3a148531bf5fe4c1f3d71690c10b248a55 Mon Sep 17 00:00:00 2001 From: Mohit Padalia Date: Tue, 8 Jan 2019 13:07:18 +0530 Subject: [PATCH 4/4] Code cleanup --- SwiftLuhn/Classes/SwiftLuhn.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SwiftLuhn/Classes/SwiftLuhn.swift b/SwiftLuhn/Classes/SwiftLuhn.swift index e643d4c..23be076 100644 --- a/SwiftLuhn/Classes/SwiftLuhn.swift +++ b/SwiftLuhn/Classes/SwiftLuhn.swift @@ -24,7 +24,7 @@ open class SwiftLuhn { var values: [CardType] = [] var index = 1 while let element = self.init(rawValue: index) { - values.append(element); + values.append(element) index += 1 } return values