-
Notifications
You must be signed in to change notification settings - Fork 3
Description
Hi @maocide!
I just discovered this project around two hours ago. After quickly reviewing it, it seems really promising. I hope it will go further in the Android FOSS community, as to my knowledge there is currently no app like this that allows live wallpapers. #12 seems like a nice feature!
I also have a few points I noticed:
-
You used a Privacy Policy Generator. If I had to guess, this is because you released your application on the Play Store. I verified the APK itself and found no data collection. I think it would be wise to add somewhere in the project, or in the policy itself, that you do not collect any user information, as many FOSS users also care about privacy. The current policy, being a template, may lead users to think that the app collects user information due to its wording.
-
You could make your GitHub releases immutable to prevent specific asset-switching attacks. This is a checkbox in your repository settings. See: https://docs.github.com/en/code-security/concepts/supply-chain-security/immutable-releases
-
For transparency, it would be nice to implement a build CI using GitHub Actions so that build logs are publicly available and users are able to confirm that the repository code was used without modifications for the build. If I were more comfortable with Android applications, I would have offered help, but I am more of a C# person. Here are some resources if that interest you:
- https://docs.github.com/en/actions/get-started/quickstart
- https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-github-cli
Another consideration: if you enable immutable releases, your build CI should create releases as drafts so you can still make final changes before publishing the release.