feat: devloop supports pre-commit checks

[lollipopkit]

To avoid the CI failures

[coderabbitai]

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

✅ Successfully generated implementation plan.

💡 Use @coderabbitai <feedback> to replan

Examples

• Example 1
• Example 2

---

🔗 Related PRs

#26 - feat(devloop): support Feishu/Lark Project issue workflow [closed]

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[coderabbitai]

Coding Plan

Approach

Add pre-commit check capabilities to the devloop plugin so that validation runs before committing code, catching issues early and avoiding failures during later review/validation phases.

Observations

This is a Claude Code plugins monorepo where the devloop plugin provides an automated development workflow (branch → implement → validate → commit → PR → review → merge). The plugin uses Markdown-based agent definitions with YAML frontmatter, shell/Python utility scripts, and a hook system for lifecycle events. Currently, the devloop-validator agent handles validation but lacks explicit pre-commit style checks. Other plugins in the repo demonstrate patterns for SessionStart hooks, doctor commands, and validation scripts that can be leveraged.

Assumptions

Assumption 1: What "pre-commit checks" means in the devloop context

Options Considered:

1. Detect and execute the target project's .pre-commit-config.yaml if present
2. Always run a fixed set of generic checks (shellcheck, markdownlint, etc.)
3. Detect project tooling and run appropriate checks dynamically

Chosen Option: 1

Rationale: Detect pre-commit framework in the target project and run it, with fallback to file-type-based linting when no pre-commit config exists. This respects user project configuration while providing value even without setup.

💡 User Tips

Regenerate the plan with different choices with @coderabbitai <feedback>.

Implementation Steps

Phase 1: Pre-commit Check Infrastructure

Create the core detection and execution logic for running pre-commit style checks on changed files before commits are made.

Task 1: Create Pre-commit Check Script

Develop a utility script that detects and executes pre-commit checks in the target project directory.

• Create plugins/devloop/scripts/pre-commit-checks.sh as the main entry point
• Implement detection logic to find .pre-commit-config.yaml in the working directory or parent directories
• When pre-commit config exists and pre-commit CLI is available, run pre-commit run --files <staged-files>
• When pre-commit is not available, provide fallback checks based on file extensions:
  • .md files: run markdownlint if available
  • .sh files: run shellcheck if available
  • .py files: run basic python syntax check (python -m py_compile)
• Output results in JSON format for programmatic consumption, following the pattern from post_tool_use_failure.py
• Include exit codes to indicate pass (0), fail (1), or skip (2, no checks applicable)

Task 2: Add Tool Availability Detection

Implement helper logic to gracefully handle missing tools.

• Add functions to check for tool availability (command -v pattern from gws-wrapper.sh)
• Provide informative messages when tools are not installed, suggesting installation
• Ensure the script never fails due to missing optional tools; skip unavailable checks gracefully
• Use the doctor command pattern for reporting what checks were skipped and why

🤖 Prompt for AI agents

Create the pre-commit check infrastructure for the devloop plugin. This phase
builds the core script that detects and executes pre-commit checks.

Create `plugins/devloop/scripts/pre-commit-checks.sh`:
- Implement detection for `.pre-commit-config.yaml` in working directory or
parent directories
- When pre-commit config and CLI are available, execute `pre-commit run --files
<staged-files>`
- Provide fallback checks by file extension: markdownlint for `.md`, shellcheck
for `.sh`, py_compile for `.py`
- Add tool availability detection using `command -v` pattern
- Handle missing tools gracefully by skipping checks with informative messages
- Output results in JSON format following `post_tool_use_failure.py` pattern
- Use exit codes: 0 for pass, 1 for fail, 2 for skip

Phase 2: Workflow Integration

Integrate pre-commit checks into the devloop development cycle to ensure checks run before code is committed.

Task 1: Update Validator Agent

Enhance the devloop-validator agent to include pre-commit checks as part of its validation responsibilities.

• Modify plugins/devloop/agents/devloop-validator.md to add pre-commit checks as an explicit validation step
• Add instructions to run the pre-commit check script on files being committed
• Update the failure reporting section to include pre-commit check failures with actionable fix suggestions
• Maintain backwards compatibility - pre-commit checks should enhance, not replace, existing validation

Task 2: Update Runner Agent

Modify the devloop-runner orchestration to explicitly gate commits on pre-commit check success.

• Update plugins/devloop/agents/devloop-runner.md Phase 4 (Commit) to require pre-commit checks pass
• Add decision logic: if pre-commit checks fail, return to implementation phase to fix issues
• Ensure the workflow clearly communicates what checks failed and how to proceed
• Add documentation in the phase description about the pre-commit gate

Task 3: Add Configuration Support

Enable users to configure pre-commit check behavior through the existing settings system.

• Update plugins/devloop/commands/devloop-enable.md to include pre-commit check settings in the configuration wizard
• Add new configuration options to the YAML frontmatter schema:
  • pre_commit_checks: enabled/disabled (default: enabled)
  • pre_commit_fallback: enabled/disabled (run fallback checks when no pre-commit config, default: enabled)
• Document configuration in the existing README.md under a new "Pre-commit Checks" section
• Ensure the pre-commit check script reads these settings from .claude/devloop.local.md

🤖 Prompt for AI agents

Integrate pre-commit checks into the devloop workflow. This phase connects the
check infrastructure to the agent orchestration and adds user configuration.

Update `plugins/devloop/agents/devloop-validator.md`:
- Add pre-commit checks as an explicit validation step
- Include instructions to run the pre-commit check script on files being
committed
- Update failure reporting to include pre-commit failures with actionable
suggestions

Update `plugins/devloop/agents/devloop-runner.md`:
- Modify Phase 4 (Commit) to require pre-commit checks pass before proceeding
- Add decision logic to return to implementation phase when checks fail
- Document the pre-commit gate in phase description

Update `plugins/devloop/commands/devloop-enable.md`:
- Add pre-commit check settings to configuration wizard
- Add YAML frontmatter options: `pre_commit_checks` (enabled/disabled, default
enabled) and `pre_commit_fallback` (enabled/disabled, default enabled)

Update README.md:
- Add "Pre-commit Checks" section documenting the feature and configuration
options

Update pre-commit check script:
- Read configuration settings from `.claude/devloop.local.md`

---

🚀 Next Steps

🤖 All AI agent prompts combined

Task: 1

Create the pre-commit check infrastructure for the devloop plugin. This phase
builds the core script that detects and executes pre-commit checks.

Create `plugins/devloop/scripts/pre-commit-checks.sh`:
- Implement detection for `.pre-commit-config.yaml` in working directory or
parent directories
- When pre-commit config and CLI are available, execute `pre-commit run --files
<staged-files>`
- Provide fallback checks by file extension: markdownlint for `.md`, shellcheck
for `.sh`, py_compile for `.py`
- Add tool availability detection using `command -v` pattern
- Handle missing tools gracefully by skipping checks with informative messages
- Output results in JSON format following `post_tool_use_failure.py` pattern
- Use exit codes: 0 for pass, 1 for fail, 2 for skip
===============================================================================

Task: 2

Integrate pre-commit checks into the devloop workflow. This phase connects the
check infrastructure to the agent orchestration and adds user configuration.

Update `plugins/devloop/agents/devloop-validator.md`:
- Add pre-commit checks as an explicit validation step
- Include instructions to run the pre-commit check script on files being
committed
- Update failure reporting to include pre-commit failures with actionable
suggestions

Update `plugins/devloop/agents/devloop-runner.md`:
- Modify Phase 4 (Commit) to require pre-commit checks pass before proceeding
- Add decision logic to return to implementation phase when checks fail
- Document the pre-commit gate in phase description

Update `plugins/devloop/commands/devloop-enable.md`:
- Add pre-commit check settings to configuration wizard
- Add YAML frontmatter options: `pre_commit_checks` (enabled/disabled, default
enabled) and `pre_commit_fallback` (enabled/disabled, default enabled)

Update README.md:
- Add "Pre-commit Checks" section documenting the feature and configuration
options

Update pre-commit check script:
- Read configuration settings from `.claude/devloop.local.md`

💡 Iterate on the plan with: @coderabbitai <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For assumption 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!