diff --git a/verifier/verifier.py b/verifier/verifier.py index c37972b..e9941f2 100644 --- a/verifier/verifier.py +++ b/verifier/verifier.py @@ -250,7 +250,26 @@ def retrieve_models(self, uri, model_dir): filename='{}/{}'.format(model_dir, model_file)) logger.info(f'Model {filename} downloaded') with tarfile.open(filename) as tar_f: - tar_f.extractall(model_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar_f, model_dir) return model_dir, model_file, model_file_sl except Exception as exc: