From 9bd3e671d0701cd45ef73fd8ad2a676679f2c646 Mon Sep 17 00:00:00 2001 From: nadilas Date: Thu, 11 Jun 2020 12:19:49 +0200 Subject: [PATCH 1/2] typo in NewEdnpoint 2nd param ``` func NewEndpoint(serviceName string, hostPort string) (*Endpoint, error) ``` --- fromenv.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fromenv.go b/fromenv.go index 5ebaffe..a58c254 100644 --- a/fromenv.go +++ b/fromenv.go @@ -30,7 +30,7 @@ func Tracer(name string) opentracing.Tracer { } // create our local service endpoint - endpoint, _ := zipkin.NewEndpoint(name, name) + endpoint, _ := zipkin.NewEndpoint(name, addr) logrus.Infof("Using Zipkin HTTP tracer: %s", addr) zipkinReporter = zipkinhttp.NewReporter(addr) From 9ee38fab8e5da4c3a6275ad5cd2288473f8f6da3 Mon Sep 17 00:00:00 2001 From: nadilas Date: Tue, 16 Jun 2020 19:16:45 +0200 Subject: [PATCH 2/2] Update fromenv.go --- fromenv.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fromenv.go b/fromenv.go index a58c254..76693bc 100644 --- a/fromenv.go +++ b/fromenv.go @@ -18,7 +18,7 @@ import ( var zipkinReporter reporter.Reporter -func Tracer(name string) opentracing.Tracer { +func Tracer(name string, opts ...zipkinhttp.ReporterOption) opentracing.Tracer { zipkinHost := os.Getenv("USE_ZIPKIN") if zipkinHost == "" { return opentracing.GlobalTracer() @@ -30,10 +30,10 @@ func Tracer(name string) opentracing.Tracer { } // create our local service endpoint - endpoint, _ := zipkin.NewEndpoint(name, addr) + endpoint, _ := zipkin.NewEndpoint(name, "localhost:0") logrus.Infof("Using Zipkin HTTP tracer: %s", addr) - zipkinReporter = zipkinhttp.NewReporter(addr) + zipkinReporter = zipkinhttp.NewReporter(addr, opts...) // initialize our tracer nativeTracer, err := zipkin.NewTracer(zipkinReporter, zipkin.WithLocalEndpoint(endpoint))