-
Notifications
You must be signed in to change notification settings - Fork 65
Closed
Description
Description
Test duplication has been identified in tests/unit/models/config/test_dump_configuration.py. The tests test_dump_configuration_with_quota_limiters and test_dump_configuration_with_quota_limiters_different_values duplicate approximately 210 lines of code, differing only in three scheduler parameters.
Details
- File:
tests/unit/models/config/test_dump_configuration.py - Tests affected:
test_dump_configuration_with_quota_limiterstest_dump_configuration_with_quota_limiters_different_values
- Issue: These tests share identical structure and assertions, varying only in the scheduler configuration parameters (
database_reconnection_countanddatabase_reconnection_delay)
Recommendation
Consider refactoring these tests using pytest parametrization to eliminate duplication and improve maintainability.
References
- Pull Request: LCORE-1126: updated docstrings in unit tests #930
- Review Comment: LCORE-1126: updated docstrings in unit tests #930 (comment)
- Reported by: @tisnik
Metadata
Metadata
Assignees
Labels
No labels