From 04dab619cb8e09024d59e11fce5af1d51acb1786 Mon Sep 17 00:00:00 2001 From: ziggie Date: Tue, 13 Jan 2026 23:08:58 +0100 Subject: [PATCH] lncfg: add deprecated no-experimental-endorsement config option Re-adds the old no-experimental-endorsement config option as a hidden, deprecated alias for no-experimental-accountability. This ensures backward compatibility for users who have the old option in their config files after the rename it. --- lncfg/protocol.go | 11 +++++++++-- lncfg/protocol_integration.go | 11 +++++++++-- sample-lnd.conf | 4 ++++ 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/lncfg/protocol.go b/lncfg/protocol.go index fbfe26411b6..b130d1b92ec 100644 --- a/lncfg/protocol.go +++ b/lncfg/protocol.go @@ -74,6 +74,11 @@ type ProtocolOptions struct { // NoExperimentalAccountabilityOption disables experimental accountability. NoExperimentalAccountabilityOption bool `long:"no-experimental-accountability" description:"do not forward experimental accountability signals"` + // NoExperimentalEndorsementOption is the deprecated name for + // NoExperimentalAccountabilityOption. It is hidden and will be removed + // in a future release. + NoExperimentalEndorsementOption bool `long:"no-experimental-endorsement" hidden:"true" description:"deprecated: use no-experimental-accountability instead"` + // CustomMessage allows the custom message APIs to handle messages with // the provided protocol numbers, which fall outside the custom message // number range. @@ -140,9 +145,11 @@ func (l *ProtocolOptions) NoRouteBlinding() bool { } // NoExpAccountability returns true if experimental accountability should be -// disabled. +// disabled. It also checks the deprecated NoExperimentalEndorsementOption for +// backwards compatibility. func (l *ProtocolOptions) NoExpAccountability() bool { - return l.NoExperimentalAccountabilityOption + return l.NoExperimentalAccountabilityOption || + l.NoExperimentalEndorsementOption } // NoQuiescence returns true if quiescence is disabled. diff --git a/lncfg/protocol_integration.go b/lncfg/protocol_integration.go index 72a26ae8b03..752a1a871ee 100644 --- a/lncfg/protocol_integration.go +++ b/lncfg/protocol_integration.go @@ -77,6 +77,11 @@ type ProtocolOptions struct { // NoExperimentalAccountabilityOption disables experimental accountability. NoExperimentalAccountabilityOption bool `long:"no-experimental-accountability" description:"do not forward experimental accountability signals"` + // NoExperimentalEndorsementOption is the deprecated name for + // NoExperimentalAccountabilityOption. It is hidden and will be removed + // in a future release. + NoExperimentalEndorsementOption bool `long:"no-experimental-endorsement" hidden:"true" description:"deprecated: use no-experimental-accountability instead"` + // NoQuiescenceOption disables quiescence for all channels. NoQuiescenceOption bool `long:"no-quiescence" description:"do not allow or advertise quiescence for any channel"` @@ -138,9 +143,11 @@ func (l *ProtocolOptions) NoRouteBlinding() bool { } // NoExpAccountability returns true if experimental accountability should be -// disabled. +// disabled. It also checks the deprecated NoExperimentalEndorsementOption for +// backwards compatibility. func (l *ProtocolOptions) NoExpAccountability() bool { - return l.NoExperimentalAccountabilityOption + return l.NoExperimentalAccountabilityOption || + l.NoExperimentalEndorsementOption } // NoQuiescence returns true if quiescence is disabled. diff --git a/sample-lnd.conf b/sample-lnd.conf index 830d42ea151..28f18b3d0b4 100644 --- a/sample-lnd.conf +++ b/sample-lnd.conf @@ -1443,6 +1443,10 @@ ; Set to disable experimental accountability signaling. ; protocol.no-experimental-accountability=false +; DEPRECATED: Use protocol.no-experimental-accountability instead. +; Set to disable experimental endorsement signaling. +; protocol.no-experimental-endorsement=false + ; Set to enable support for RBF based coop close. ; protocol.rbf-coop-close=false