Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Forking works even if Github user name is not set #40

@louisrli

Description

@louisrli

In lesson_downloader.rb, there's a line of code that says:

fork_repo if lesson.use_student_fork

If you don't have a Github username linked to your learn.co account, this line does not crash; nothing goes wrong, however, nothing is actually forked, because it doesn't know where to fork to.

This should be a fatal error or somewhere upstream should enforce that the Github username is linked if it attempts to fork.

To be clear, to replicate this bug:

  1. Sign up for a learn.co cohort
  2. Do NOT link your Github
  3. Run learn open <some lesson that attempts forking>
  4. The fork code will run without an error
  5. No repo will actually be forked

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions