Failures in get_peak_rss() should fail the application instead of silently returning 0

[yurivict]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filed.
    • Specifically, check out the wishlist, open RFCs,
      or feature requests.
  • Reduced the issue to a self-contained, reproducible test case.

Description

get_peak_rss() on FreeBSD was always failing due to a wrong /proc/... path and all tests still succeeded.

This function should be changed to hard-fail when any system call fails. In its current condition it might be silently failing for whatever reasons and users are never notified.