From 8c8ca7fa4c0c1b6d008d1893c31dc1b061886d37 Mon Sep 17 00:00:00 2001 From: Liam Doan Date: Tue, 4 Mar 2025 21:29:31 +0000 Subject: [PATCH 1/3] fix: remove Figure prefix from captions --- index.ts | 15 +++++++-------- src/template.latex | 4 ++++ 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/index.ts b/index.ts index a2829a8..af2af91 100644 --- a/index.ts +++ b/index.ts @@ -13,7 +13,7 @@ export const schema = z.array( fileName: z.string(), typeOfFile: TypeOfFileSchema, markdown: z.string(), - isMilkdown: z.boolean().optional(), + implicitFigures: z.boolean().optional(), }) ); @@ -57,12 +57,11 @@ export const handler = async function ( pandocArgs: string[], destFilePath: string, markdown: string, - isMilkdown: boolean = true + implicitFigures: boolean = false ) => { // pandoc source format - // If Milkdown, disable the implicit_figures extension to remove all image captions - const fromString = isMilkdown ? "markdown-implicit_figures" : "markdown+implicit_figures"; - // const fromString = "markdown+implicit_figures"; + // If implicitFigures, enable the implicit_figures extension and add image captions + const fromString = implicitFigures ? "markdown+implicit_figures" : "markdown-implicit_figures"; try { await pdcTs.Execute({ @@ -137,7 +136,7 @@ export const handler = async function ( let url = ""; for (let eachRequestData of requestData) { const markdown = eachRequestData.markdown; - const isMilkdown = eachRequestData.isMilkdown; + const implicitFigures = eachRequestData.implicitFigures; switch (eachRequestData.typeOfFile) { case "PDF": @@ -147,7 +146,7 @@ export const handler = async function ( ["--pdf-engine=xelatex", `--template=./template.latex`], localPathPDF, markdown, - isMilkdown + implicitFigures ); if (generatePDFResult?.statusCode) { @@ -164,7 +163,7 @@ export const handler = async function ( [`--template=./template.latex`], localPathTEX, markdown, - isMilkdown + implicitFigures ); const s3PathTEX = `${eachRequestData.userId}/${filenameTEX}`; diff --git a/src/template.latex b/src/template.latex index 3e7d1ca..bb8d070 100644 --- a/src/template.latex +++ b/src/template.latex @@ -220,6 +220,10 @@ $endif$ \usepackage{float} \floatplacement{figure}{H} +% Remove "Figure X." prefix from captions +\usepackage{caption} +\captionsetup[figure]{labelformat=empty} + % Lambda customisation \let\OldRule\rule From 7e7d99453deced31583fddef70ea0f0854af073d Mon Sep 17 00:00:00 2001 From: Liam Doan Date: Tue, 4 Mar 2025 21:39:44 +0000 Subject: [PATCH 2/3] chore: test that caption removal works in dev deploy --- index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.ts b/index.ts index af2af91..5f5f69b 100644 --- a/index.ts +++ b/index.ts @@ -136,7 +136,7 @@ export const handler = async function ( let url = ""; for (let eachRequestData of requestData) { const markdown = eachRequestData.markdown; - const implicitFigures = eachRequestData.implicitFigures; + const implicitFigures = true; switch (eachRequestData.typeOfFile) { case "PDF": From 9a6e0b288bf214d8bfc224dd36cc2c7912168c05 Mon Sep 17 00:00:00 2001 From: Liam Doan Date: Tue, 4 Mar 2025 21:42:45 +0000 Subject: [PATCH 3/3] chore: it works! revert back --- index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.ts b/index.ts index 5f5f69b..af2af91 100644 --- a/index.ts +++ b/index.ts @@ -136,7 +136,7 @@ export const handler = async function ( let url = ""; for (let eachRequestData of requestData) { const markdown = eachRequestData.markdown; - const implicitFigures = true; + const implicitFigures = eachRequestData.implicitFigures; switch (eachRequestData.typeOfFile) { case "PDF":