From a57f3aa00d6931ed87a6798fb4f3e1fbabb08113 Mon Sep 17 00:00:00 2001 From: Krzysiek Karbowiak Date: Wed, 3 Dec 2025 16:03:39 +0100 Subject: [PATCH 1/4] Add code comments --- include/argparse.hpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/argparse.hpp b/include/argparse.hpp index 0999a7d..f5960ff 100644 --- a/include/argparse.hpp +++ b/include/argparse.hpp @@ -812,6 +812,7 @@ namespace argparse auto check_errors(ArgumentImpl const & /* impl */, std::string_view /* value */, std::ranges::view auto /* tokens */) const -> void { + // skip } auto assign_non_present_value(ArgumentImpl const & /* impl */, std::any & value) const -> void @@ -831,6 +832,7 @@ namespace argparse auto check_errors(ArgumentImpl const & /* impl */, std::string_view /* value */, std::ranges::view auto /* tokens */) const -> void { + // skip } auto assign_non_present_value(ArgumentImpl const & /* impl */, std::any & value) const -> void From d31776068051651c907b62116dafae96121d9f99 Mon Sep 17 00:00:00 2001 From: Krzysiek Karbowiak Date: Wed, 3 Dec 2025 16:04:14 +0100 Subject: [PATCH 2/4] Move private section --- include/argparse.hpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/argparse.hpp b/include/argparse.hpp index f5960ff..f96c729 100644 --- a/include/argparse.hpp +++ b/include/argparse.hpp @@ -1469,11 +1469,6 @@ namespace argparse }); } - private: - ArgumentImpl m_impl; - std::any m_value; - bool m_present = false; - public: explicit OptionalArgument(Options options) : m_impl(std::move(options)) @@ -1640,6 +1635,11 @@ namespace argparse { return m_impl.get_nargs_option(); } + + private: + ArgumentImpl m_impl; + std::any m_value; + bool m_present = false; }; using ArgumentVariant = std::variant; From 015c0439c27cd5d1fa75d380dceac4b5fdb89f2b Mon Sep 17 00:00:00 2001 From: Krzysiek Karbowiak Date: Wed, 3 Dec 2025 16:05:15 +0100 Subject: [PATCH 3/4] Use if statements with initialiser --- include/argparse.hpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/argparse.hpp b/include/argparse.hpp index f96c729..30b18ee 100644 --- a/include/argparse.hpp +++ b/include/argparse.hpp @@ -1515,9 +1515,9 @@ namespace argparse auto get_dest_name() const -> std::string override { - if (!m_impl.get_dest().empty()) + if (auto const & dest = m_impl.get_dest(); !dest.empty()) { - return m_impl.get_dest(); + return dest; } auto dest = get_name_for_dest(); @@ -1529,9 +1529,9 @@ namespace argparse auto get_metavar_name() const -> std::string override { - if (!m_impl.get_metavar().empty()) + if (auto const & metavar = m_impl.get_metavar(); !metavar.empty()) { - return m_impl.get_metavar(); + return metavar; } auto metavar = get_dest_name(); From 5894941a1b399ec40b99e18ae61b3c3a4437bd27 Mon Sep 17 00:00:00 2001 From: Krzysiek Karbowiak Date: Wed, 3 Dec 2025 16:06:01 +0100 Subject: [PATCH 4/4] Use emplace_back function instead of push_back --- include/argparse.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/argparse.hpp b/include/argparse.hpp index 30b18ee..a961499 100644 --- a/include/argparse.hpp +++ b/include/argparse.hpp @@ -1920,11 +1920,11 @@ namespace argparse if (is_positional()) { - m_arguments.push_back(PositionalArgument(std::move(m_options))); + m_arguments.emplace_back(PositionalArgument(std::move(m_options))); } else { - m_arguments.push_back(OptionalArgument(std::move(m_options))); + m_arguments.emplace_back(OptionalArgument(std::move(m_options))); } }