Parse fails when files have multiple timestamps for single line of text

[1hitsong]

When attempting to parse a lyric file that has the following line, the parser failed.

[00:51.00][01:29.99][01:48.29][02:31.00][02:41.99]You gotta fight !

The expected outcome was for the parser to use the text "You gotta fight !" at each of the five time stamps.

[andy840119]

Thanks for report the issue!
This issue will be fixed in the #41 and make a new release soon 🎉 .

[1hitsong]

Awesome! Thanks for hopping on this so quickly

Looking at the PR for the fix, would this result in the output being option 1 or option 2?

Option 1
[00:51.00]You gotta fight !

or Option 2
[00:51.00]You gotta fight !
[01:29.99]You gotta fight !
[01:48.29]You gotta fight !
[02:31.00]You gotta fight !
[02:41.99]You gotta fight !

[andy840119]

The result will be the option 1.

[andy840119]

And note that new NuGet package has been released!

see:
https://www.nuget.org/packages/LrcParser

[1hitsong]

The result will be the option 1.

Cool. Just making sure I'm following.

I've seen a lot of sites that use the multiple timestamps in a way that means option 2, but If that's not to the LRC standard, then option 1 makes the most sense.

[andy840119]

Guess this issue is fixed 🚀

[Shadowghost]

@andy840119 in my opinion this is not the correct fix for the issue.
Implementing Option 2 mentioned above would make the lib adhere to the basic LRC format.
Multiple timestamps on the same line should result in that line appearing on those timestamp. Dropping all except the first timestamp removes quite any chorus lyrics from songs after the first occurrence.

[andy840119]

https://en.wikipedia.org/wiki/LRC_(file_format)
Seems there's two usage for .lrc format

One is for sceeen text:

[00:21.10][00:45.10]Repeating lyrics (e.g. chorus)

Another one is for karaoke format:

[mm:ss.xx] <mm:ss.xx> line 1 word 1 <mm:ss.xx> line 1 word 2 <mm:ss.xx> ... line 1 last word <mm:ss.xx>

But (as i remember) some software might export the .lrc with those format as well:

[mm:ss.xx] [mm:ss.xx] line 1 word 1 [mm:ss.xx] line 1 word 2 [mm:ss.xx] ... line 1 last word [mm:ss.xx]

Also, did you have idea for handling those cases?
And will you willing to make the PR for that because currently I'm focusing on another project😢
Might have no enough time to solve this issue.

https://suwa.pupu.jp/RhythmicaLyrics.html
This is the software I made the .lrc file before.

[Shadowghost]

I already took a look at the codebase and it likely requires some API changes. I'll try to come up with a PR over the weekend.

[andy840119]

I already took a look at the codebase and it likely requires some API changes. I'll try to come up with a PR over the weekend.

I think in this case it should not repeat:

[mm:ss.xx][mm:ss.xx] line 1 word 1 [mm:ss.xx] line 1 word 2 [mm:ss.xx] ... line 1 last word [mm:ss.xx]

Did you have any idea for handle this case?
Or can you describe how will you do for this case in order to reduce the review time?

Api change is OK for me, but would be better to explain why 👌🏼

[Shadowghost]

This is taking abit longer than expected, but what I did up until now:

• Move the timestamp into TextIndex since the current structure does not allow multipletimestamps for the same starting index (we are using a dict)
• Add handling for multi occurrence.

Looking at your post above I've got a question:
According to wikipedia karaoke format is like this (duration infront of word)

[mm:ss.xx] <mm:ss.xx> line 1 word 1 <mm:ss.xx> line 1 word 2 <mm:ss.xx> ... line 1 last word

But according to your example it can also be this:

[mm:ss.xx] <mm:ss.xx> line 1 word 1 <mm:ss.xx> line 1 word 2 <mm:ss.xx> ... line 1 last word <mm:ss.xx>

What are the timestamps in this case for?