Should other instructions be an array?

[austbot]

In the quote response I'm seeing other instructions coming back as an [] but in the deserialization code found here

jupiter-quote-api-node/generated/models/SwapInstructionsResponse.ts

Line 91 in 07165d5

'otherInstructions': InstructionFromJSON(json['otherInstructions']),

its being treated like an object.

Here is some output on a USDC to BONK quote

Swap instructions received: {
  otherInstructions: [],
  computeBudgetInstructions: [
    {
      programId: "ComputeBudget111111111111111111111111111111",
      accounts: [],
      data: "AljXAwA=",
    }, {
      programId: "ComputeBudget111111111111111111111111111111",
      accounts: [],
      data: "AzAwBgAAAAAA",
    }
  ],

Here is my request

swapRequest {
  userPublicKey: "<redacted>",
  wrapAndUnwrapSol: true,
  useSharedAccounts: undefined,
  feeAccount: undefined,
  trackingAccount: undefined,
  prioritizationFeeLamports: {
    priorityLevelWithMaxLamports: {
      priorityLevel: "medium",
      maxLamports: 1000000,
    },
    jitoTipLamports: undefined,
  },
  asLegacyTransaction: undefined,
  destinationTokenAccount: undefined,
  dynamicComputeUnitLimit: true,
  skipUserAccountsRpcCalls: undefined,
  dynamicSlippage: undefined,
  computeUnitPriceMicroLamports: undefined,
  quoteResponse: {
    inputMint: "EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v",
    inAmount: "10000000",
    outputMint: "DezXAZ8z7PnrnRJjz3wXBoRgixCa6xjnB7YaB1pPB263",
    outAmount: "73945723793",
    otherAmountThreshold: "73871778070",
    swapMode: "ExactIn",
    slippageBps: 10,
    platformFee: undefined,
    priceImpactPct: "0.0004607674230336317235341978",
....

[igorescobar-moonpay]

The fact that this field is an empty array it is blowing up the code:

Cannot read properties of undefined (reading 'map')
TypeError: Cannot read properties of undefined (reading 'map')
    at InstructionFromJSONTyped (node_modules/@jup-ag/api/dist/index.js:518:34)
    at InstructionFromJSON (node_modules/@jup-ag/api/dist/index.js:510:10)
    at SwapInstructionsResponseFromJSONTyped (node_modules/@jup-ag/api/dist/index.js:740:26)
    at SwapInstructionsResponseFromJSON (node_modules/@jup-ag/api/dist/index.js:733:10)
    at JSONApiResponse.transformer (node_modules/@jup-ag/api/dist/index.js:1033:59)
    at JSONApiResponse.<anonymous> (node_modules/@jup-ag/api/dist/index.js:399:19)

It starts here:

"otherInstructions": InstructionFromJSON(json["otherInstructions"]),

Then here:

function InstructionFromJSONTyped(json, ignoreDiscriminator) {
  if (json === void 0 || json === null) {
    return json;
  }
  return {
    "programId": json["programId"],
    "accounts": json["accounts"].map(AccountMetaFromJSON),
    "data": json["data"]
  };
}

And it blows up here:

"accounts": json["accounts"].map(AccountMetaFromJSON),

as json["accounts"] is undefined. 🤔

[ilkamo]

Hey, I have encountered the same issue. The following swagger should be updated.

Instead of:

SwapInstructionsResponse:
      type: object
      properties:
        otherInstructions:
          description: "If you set `{\"prioritizationFeeLamports\": {\"jitoTipLamports\": 5000}}`, you will see a custom tip instruction to Jito here."
          $ref: '#/components/schemas/Instruction'

This should be:

SwapInstructionsResponse:
      type: object
      properties:
        otherInstructions:
          description: "If you set `{\"prioritizationFeeLamports\": {\"jitoTipLamports\": 5000}}`, you will see a custom tip instruction to Jito here."
          type: array
          items:
            $ref: '#/components/schemas/Instruction'

I have already fixed it in the jupiter-go library: ilkamo/jupiter-go#42

@sssionggg @0xYankee-Raccoons could you please take care of it?

[0xYankee-Raccoons]

hey all, thanks for flagging, we have a fix coming up to resolve this, sorry about that.

https://github.com/jup-ag/jupiter-quote-api-node/pull/60/files#diff-8b1949772e223a1da6a2049ada2733fa506410975b241cf86cf44c7a8665bc62R385

@austbot @igorescobar-moonpay @ilkamo

[igorescobar-moonpay]

news?

[0xYankee-Raccoons]

hey sorry for the wait, this is fixed and published

d9f0b26

@ilkamo @austbot @igorescobar-moonpay