Open
Conversation
minor ES6 syntax changes
…encies. big thanks to isaacs
adding ci\cd via node.js on ubuntu-LTS
…anged that in tests
blank space
Author
|
Fixed skipped tests and everything works quite well |
jonvuri
reviewed
Jun 23, 2025
Owner
jonvuri
left a comment
jonvuri
left a comment
There was a problem hiding this comment.
Hey there, thank you for making this PR! Sorry for the late response, been a while since I looked around here.
One question about the dependencies.
| "license": "MIT" | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "assert": "^2.1.0", |
Owner
There was a problem hiding this comment.
Why were these dependencies added?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated your repository to es6 syntax, some of the tests are still in progress, those are commented, for not interrupt
Thank you.