Skip to content

Character Level Embedding #12

@KazutoshiShinoda

Description

@KazutoshiShinoda

x = x.sum(2) # (N, seq_len, c_embd_size)

I feel strange to see this code.
Why do you sum over word_len dimension?
Why don't you apply 1D filter over word_len dimension?

Thank you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions