Stuff for report

[binnimar]

Need to have the following for the report

the numbers of capture/kill and acknowledgment messages sent/received
the maximum levels reached by the processes
the number of times every process is captured

[binnimar]

Tried to implement this already, please verify that it makes sense @wordempire

[jellelicht]

I'm looking at it right now, give some minutes 😸

[jellelicht]

Not entirely sure if what I just pushed is correct in 9252bd1, but this is my interpretation of the comments in the slides. Do you agree, or am I failing to see something obvious here?

[jellelicht]

Also, @binnimar , I ❤️ GitHub linking to commits 👯

[jellelicht]

Update e5cc250: Added the candidate statistics as well. Could you review?

[binnimar]

Looks promising, I'll run some test runs tomorrow and see how it goes

[binnimar]

Did you edit the file on github or did you do it in Eclipse? The Client2 file I have has some errors regarding the noCaptureSent variable. You instantiate it in the Client2 class but use it in the Candidate class which doesnt really work - could you please have a look?

[jellelicht]

@binnimar You are totally right. I don't know what happened there. Should be okay now. Could you review if the statistics make any sense? I'm not sure what to make of the candidate processes that are killed, maybe it would make sense to include that statistic in the final message as well (the killed member)

[binnimar]

Sorry for the late answer, I was away yesterday. I think we should include more than less statistic as we can always filter out unneeded information for the report.

Also I am not sure about the statistics, a lot of the numbers seem to end up being 0, could you please verify

[jellelicht]

I just uploaded a new version of the logging stuff. It seems to work pretty well now. I can write the introduction of the 'report', plus a test case, and maybe you can write 2 test cases as well?

I was thinking of this structure:
For each test case, give the amount of processess (and how many candidate processes there turned out to be).
Give the result for each process (nicely tagged by '[RESULTS]').

This is an example of the output I have now, for candidate processes:

client_12.log:[RESULTS] PId: 11 Acks: 0 Captured: 0 Kills: 0 capturesSent: 29 ackedCaptures/maxLevel: 29 midCapture: false Killed: falseUntraversed size: 0

client_13.log:[RESULTS] PId: 29 Acks: 0 Captured: 0 Kills: 0 capturesSent: 1 ackedCaptures/maxLevel: 0 midCapture: true Killed: trueUntraversed size: 29

client_14.log:[RESULTS] PId: 0 Acks: 0 Captured: 0 Kills: 0 capturesSent: 1 ackedCaptures/maxLevel: 0 midCapture: true Killed: trueUntraversed size: 29

client_15.log:[RESULTS] PId: 21 Acks: 0 Captured: 0 Kills: 0 capturesSent: 1 ackedCaptures/maxLevel: 0 midCapture: true Killed: trueUntraversed size: 29

client_16.log:[RESULTS] PId: 19 Acks: 0 Captured: 0 Kills: 0 capturesSent: 1 ackedCaptures/maxLevel: 0 midCapture: true Killed: trueUntraversed size: 29
client_17.log:[RESULTS] PId: 17 Acks: 0 Captured: 0 Kills: 0 capturesSent: 1 ackedCaptures/maxLevel: 0 midCapture: true Killed: trueUntraversed size: 29

client_1.log:[RESULTS] PId: 18 Acks: 0 Captured: 0 Kills: 0 capturesSent: 2 ackedCaptures/maxLevel: 1 midCapture: true Killed: trueUntraversed size: 28

client_20.log:[RESULTS] PId: 1 Acks: 0 Captured: 0 Kills: 0 capturesSent: 1 ackedCaptures/maxLevel: 0 midCapture: true Killed: trueUntraversed size: 29

client_22.log:[RESULTS] PId: 10 Acks: 0 Captured: 0 Kills: 0 capturesSent: 4 ackedCaptures/maxLevel: 3 midCapture: true Killed: trueUntraversed size: 26

client_23.log:[RESULTS] PId: 9 Acks: 0 Captured: 0 Kills: 0 capturesSent: 1 ackedCaptures/maxLevel: 0 midCapture: true Killed: trueUntraversed size: 29

client_27.log:[RESULTS] PId: 26 Acks: 0 Captured: 0 Kills: 0 capturesSent: 2 ackedCaptures/maxLevel: 1 midCapture: true Killed: trueUntraversed size: 28

client_28.log:[RESULTS] PId: 5 Acks: 0 Captured: 0 Kills: 0 capturesSent: 1 ackedCaptures/maxLevel: 0 midCapture: true Killed: trueUntraversed size: 29

client_5.log:[RESULTS] PId: 6 Acks: 0 Captured: 0 Kills: 0 capturesSent: 1 ackedCaptures/maxLevel: 0 midCapture: true Killed: trueUntraversed size: 29

client_9.log:[RESULTS] PId: 8 Acks: 0 Captured: 0 Kills: 0 capturesSent: 3 ackedCaptures/maxLevel: 2 midCapture: true Killed: trueUntraversed size: 27

[binnimar]

Looks good, well done. I can do a couple of test cases thats not a problem, could you perhaps tell me what your test case will be so we don't do the same one?

[jellelicht]

Mine is the one you just saw, so with 30 clients ;-)

[jellelicht]

So maybe one with 1 client, and one with 10 clients?

[binnimar]

sounds good - will do

[jellelicht]

FYI, if you are 'in' the log directory, give grep RESULTS * on a command line (bash thingy) to see only the relevant lines