Skip to content

Multiple copies of Geometry::connected_components() #116

@cakarsubasi

Description

@cakarsubasi

There are two copies of the connected_components function, one in Graph.cpp, the other in graph_util.cpp that do the exact same thing. The compiler did not complain about this because one takes a NodeSetUnordered (aka std::unordered_set) and the other takes an AMGraph::NodeSet (aka std::set). However, making these both phmap::hash_set ends up violating the one definition rule.

We can remove either one. Alternatively, it might be a good idea to just make this a template since it can work with arbitrary set types.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions