From 67e9b815163201d5869a5765fa8633fc4afa866c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mattias=20=C3=85slund?= Date: Sat, 23 Jan 2016 19:09:38 +0100 Subject: [PATCH] Suggestion how to clean up socket.io server test a bit --- src/server/_server_test.js | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/server/_server_test.js b/src/server/_server_test.js index 9ba5a5582..8b252f9da 100644 --- a/src/server/_server_test.js +++ b/src/server/_server_test.js @@ -159,15 +159,14 @@ it("broadcasts mouse message from one client to all others", function(done) { var EXPECTED_DATA = "mouse data"; - var emitter = createSocket(); - var receiver1 = createSocket(); - var receiver2 = createSocket(); + var clients = createSockets(3); + var emitter = clients[0]; + var receivers = clients.slice().splice(1); emitter.on("mouse", function() { assert.fail("emitter should not receive its own events"); }); - - async.each([ receiver1, receiver2 ], function(client, next) { + async.each(receivers, function(client, next) { client.on("mouse", function(data) { assert.equal(data, EXPECTED_DATA); next(); @@ -177,12 +176,15 @@ emitter.emit("mouse", EXPECTED_DATA); function end() { - async.each([ emitter, receiver1, receiver2 ], function(socket, next) { - closeSocket(socket, next); - }, done); + async.each(clients, closeSocket, done); } }); + function createSockets(count){ + return Array.from({length: count}, createSocket); + //Or without ES6: return Array.apply(null, Array(count)).map(createSocket); + } + function createSocket() { return io("http://localhost:" + PORT); }