InsertBuilder.values() is not able to know previous added input values

[pr7vinas]

I might be doing something wrong, but It seems that the InsertBuilder.values() is not able to know previous added input values.

Given the following code:

List<User> users = someResourceProvider.getAllMyUsers(); // lets suppose that I have only two users
InsertBuilder insertBuilder = InsertBuilder.into("myTable").columns("name","phone");

users.forEach(user -> insertBuilder.values(user.getName(),user.getPhone());

String query = insertBuilder.build().getQuery().toString();

I was expecting String query to contain something similar to this:

INSERT INTO myTable (name,phone) VALUES (?,?) , (?,?);

However I'm getting this output:

INSERT INTO myTable (name,phone) VALUES (?,?) VALUES (?,?);

Am I missing something?
It might be the case that I misinterpreted what InsertBuilder.values() is supposed to do.

I would appreciate some feedback.
Thank you very much for your time.
Cheers.

[tiagosimao]

The current implementation of InsertBuilder is somewhat stateless, not much more than a dumb appender.
It might be interesting to support the kind of usage you are trying to do, but for now, the way to achieve multi-row insert is with the .values(Iterable rows, Function<ROW, Iterable> mapper) method.

insertBuilder.values(users, user-> new Object[]{ user.getName(), user.getPhone() })

There's an example here in a test class.
Hope this helps!