From bad43d875553df188ff2fe31c46a276ac9626094 Mon Sep 17 00:00:00 2001
From: iptoux <iptoux@gmail.com>
Date: Sun, 20 Apr 2025 11:42:41 +0200
Subject: [PATCH] Refactor task display with encrypted description handling

Introduce a specific `displayTasks` view-model to manage decrypted task descriptions separately from original data. This enhances separation of concerns, optimizes UI updates, and ensures better maintainability. The drag-and-drop functionality was updated to handle both the original and display arrays in sync.
---
 .../task-list/task-list.component.html        |  2 +-
 .../task-list/task-list.component.ts          | 37 +++++++++++++++++--
 2 files changed, 35 insertions(+), 4 deletions(-)

diff --git a/src/app/components/task-list/task-list.component.html b/src/app/components/task-list/task-list.component.html
index f44045a..8b1c5cc 100644
--- a/src/app/components/task-list/task-list.component.html
+++ b/src/app/components/task-list/task-list.component.html
@@ -9,7 +9,7 @@
 
       <form>
         <ul cdkDropList (cdkDropListDropped)="drop($event)">
-          <li *ngFor="let task of tasks; index as id" cdkDrag
+          <li *ngFor="let task of displayTasks; index as id" cdkDrag
               [style.position]="'relative'"
               [style.overflow]="'hidden'"
               class="d-flex align-items-center justify-content-between"
diff --git a/src/app/components/task-list/task-list.component.ts b/src/app/components/task-list/task-list.component.ts
index dfb2309..6fab0bd 100644
--- a/src/app/components/task-list/task-list.component.ts
+++ b/src/app/components/task-list/task-list.component.ts
@@ -11,6 +11,12 @@ import {ModalService} from '../../services/modal.service';
 import {NotificationService} from '../../services/notification.service';
 import {AccountService} from '../../services/account.service';
 
+// Definiere ein View-Modell nur für die Anzeige
+interface TaskView extends Task {
+  decryptedDescription: string;
+}
+
+
 @Component({
   selector: 'app-task-list',
   imports: [
@@ -33,6 +39,9 @@ export class TaskListComponent implements OnInit, OnDestroy {
   private subscription: Subscription | null = null;
   private notificationService = inject(NotificationService)
 
+  // Das ist das View-Modell, das nur für die Anzeige verwendet wird
+  displayTasks: TaskView[] = [];
+
 
   constructor(private tasksService: TasksService,
               private darkModeService: DarkModeService,
@@ -188,13 +197,26 @@ export class TaskListComponent implements OnInit, OnDestroy {
     }
   }
 
+  private async updateDisplayTasks() {
+    // Erstelle eine neue Instanz des Display-Arrays
+    this.displayTasks = [];
+
+    // Entschlüssle jeden Task und füge ihn dem Display-Array hinzu
+    for (const task of this.tasks) {
+      const displayTask = {
+        ...task, // Alle Eigenschaften kopieren
+        decryptedDescription: await this.decryptTaskDesk(task.description)
+      };
+      this.displayTasks.push(displayTask);
+    }
+  }
 
   ngOnInit() {
     this.subscription = this.tasksService.tasks$.subscribe(async tasks => {
       this.tasks = tasks;
-      for (const task of this.tasks) {
-        task.decryptedDescription = await this.decryptTaskDesk(task.description);
-      }
+      // Anzeige-Tasks erstellen und entschlüsseln
+      await this.updateDisplayTasks();
+
       this.checkTasksDueSoon();
     });
   }
@@ -215,11 +237,20 @@ export class TaskListComponent implements OnInit, OnDestroy {
   }
 
   drop(event: CdkDragDrop<Task[]>): void {
+    // Aktualisiere zuerst das Anzeige-Array für sofortige UI-Aktualisierung
+    moveItemInArray(this.displayTasks, event.previousIndex, event.currentIndex);
+
+    // Dann aktualisiere das Original-Array in der gleichen Weise
     moveItemInArray(this.tasks, event.previousIndex, event.currentIndex);
 
     this.tasks.forEach((task, index) => {
       task.order = index;
     });
+
+    this.displayTasks.forEach((task, index) => {
+      task.order = index;
+    });
+
    this.tasksService.updateTasksOrderForFilter(this.tasks);
   }
 }