Skip to content
This repository was archived by the owner on Nov 11, 2021. It is now read-only.
This repository was archived by the owner on Nov 11, 2021. It is now read-only.

Comments on "Thinking…" tutorial #1

@vmx

Description

@vmx

@mikeal If it would've been a PR, I could've commented there.

In the Addressing section your write:

We encode this data using JSON. Now it has been serialized to a binary representation we can store and/or send to someone else.

I find that confusing as I don't think of JSON as a binary representation. Either make this CBOR or remove the binary representation part. I lean towards CBOR, as doing JSON things within JS might confuse people as it's really similar to their original data.

Later you introduce DAG-CBOR, though even I find it confusing. Why can't you use json? Oh wait, is json not dag-json? If that's the case I would start directly with DAG-CBOR to avoid confusion. If you are new to all this Block.encoder({ name }, 'json') might read as "I want to encode JSON into a Block" and not as "I want this data to be encoded in a Block of JSON".

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions