From a92ca6c83fa1fa1cd33bde9fcccb6aca5628a67c Mon Sep 17 00:00:00 2001 From: Martin Lowinski Date: Thu, 8 Aug 2019 12:31:19 +0200 Subject: [PATCH 1/2] Separate HTTP basic auth from JWT auth in README --- README.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 941aa87..928c95c 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,8 @@ new PluginHttp({ }, incoming: { // (required) describes the http server port: 4000, // (required) port to listen on - secret: 'shhh' // (required) secret for auth (see Protocol section) + secret: 'shhh', // secret for JWT auth (see Protocol section) + secretToken: 'shhh' // (required) secret for auth (see Protocol section) }, outgoing: { // (required) describes outgoing http calls url: 'https://example.com/ilp/%', // (required) endpoint to POST packets to @@ -34,7 +35,8 @@ new PluginHttp({ // segment after this plugin's own address will be filled where the `%` is // when routing packets. - secret: 'othersecret', // (required) secret for auth (see Protocol section) + secret: 'othersecret', // secret for JWT auth (see Protocol section) + secretToken: 'othersecret', // (required) secret for auth (see Protocol section) http2: false, // whether `url` uses http2 tokenExpiry: 10 * 1000, // how often to sign a new token for auth name: 'alice' // name to send in `ILP-Peer-Name` header, for ilp addr. From 6a7b6d3f8fd32c1284346b2b082624f0721458c9 Mon Sep 17 00:00:00 2001 From: Martin Lowinski Date: Fri, 16 Aug 2019 12:12:09 +0200 Subject: [PATCH 2/2] Comment out `secret` --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 928c95c..92dfa66 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,7 @@ new PluginHttp({ }, incoming: { // (required) describes the http server port: 4000, // (required) port to listen on - secret: 'shhh', // secret for JWT auth (see Protocol section) + // secret: 'shhh', // secret for JWT auth (see Protocol section) secretToken: 'shhh' // (required) secret for auth (see Protocol section) }, outgoing: { // (required) describes outgoing http calls @@ -35,7 +35,7 @@ new PluginHttp({ // segment after this plugin's own address will be filled where the `%` is // when routing packets. - secret: 'othersecret', // secret for JWT auth (see Protocol section) + // secret: 'othersecret', // secret for JWT auth (see Protocol section) secretToken: 'othersecret', // (required) secret for auth (see Protocol section) http2: false, // whether `url` uses http2 tokenExpiry: 10 * 1000, // how often to sign a new token for auth