Skip to content

ice-2.2.9/src/ice_main.c code clarifiation #38

@XavierMika

Description

@XavierMika

Hi,

Please clarify this portion of code :

    case TC_SETUP_BLOCK:
            return flow_block_cb_setup_simple(type_data,
                                              &ice_block_cb_list,
                                              ice_setup_tc_block_cb,
                                              np, np, true);

#ifdef HAVE_TC_ETF_QOPT_OFFLOAD <------------------
case TC_SETUP_QDISC_ETF: <------------------
return ice_offload_txtime(netdev, type_data);
#else
return -EOPNOTSUPP;
#endif /* HAVE_TC_ETF_QOPT_OFFLOAD */
default:
return -EOPNOTSUPP;
}

shouldn't it be:

    case TC_SETUP_BLOCK:
            return flow_block_cb_setup_simple(type_data,
                                              &ice_block_cb_list,
                                              ice_setup_tc_block_cb,
                                              np, np, true);
    case TC_SETUP_QDISC_ETF:                                            <------------------

#ifdef HAVE_TC_ETF_QOPT_OFFLOAD <------------------
return ice_offload_txtime(netdev, type_data);
#else
return -EOPNOTSUPP;
#endif /* HAVE_TC_ETF_QOPT_OFFLOAD */
default:
return -EOPNOTSUPP;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions