Skip to content

Obsolete functions or functions that can be simplified. #130

@kinkayd

Description

@kinkayd

Merge Rooms : No longer necessary, since the hash from gmcp.room.info positively identifies a room, no need to merge rooms, since different rooms will have different hashes and thus different room ID's.

function set_room : At the end of this functions, an onMoveMap event is raised... yet you have no handler to handle the event. Is this an event handled by the mapper that I haven't found?

function check_room(...) : Since rooms are positively identified by a hash, why do you check against room name and exits? Big issue I have with this, is that some rooms have exits that are not obvious. Once I use said exit, the exit is created, and thus this function no longer identifies a perfectly valid room and won't show you being in that room.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions