How to use custom ISqlHooks?

[brendonparker]

I seems like the idea with AddDbConnectionFactoryWithHooks is that you could use the IoC container to register your own ISqlHooks, but then it doesn't look like that is ever used.

For example, both the ContextlessLoggingFactory and ContextfulLoggingFactory call CreateConnection specifying the hooks which are manually instantiated in their respective classes...

_hooks = new LoggingHook<T>(logger, config);

Am I missing something?

[brendonparker]

One idea...

1. Make Empty public (currently internal).
2. Add another extension method, something like: AddDbConnectionFactoryUsingCustomHooks

Example implementation:

public static IServiceCollection AddDbConnectionFactoryUsingCustomHooks(
    this IServiceCollection services,
    Func<IServiceProvider, DbConnection> factory,
    ServiceLifetime lifetime = ServiceLifetime.Scoped)
{
    object FactoryWrapper(IServiceProvider x) =>
        new ContextlessLoggingFactory(
            x.GetRequiredService<ISqlHooks<Empty>>(),
            () => factory(x));

    services.TryAdd(new ServiceDescriptor(typeof(IDbConnectionFactory), FactoryWrapper, lifetime));
    return services;
}

So this is adding a constructor to ContextlessLoggingFactory:

public ContextlessLoggingFactory(
    ISqlHooks<Empty> hooks, Func<DbConnection> factory)
{
    _hooks = hooks;
    _factory = new WrappedConnectionFactory<Empty>(factory);
}

IDK, feels kinda heavy handed.

Really, what I am after is a custom ISqlHooks implementation. Also, would be nice to have some other methods on that interface, specifically: CommandExecuting and CommandErrored. I'm trying to wire it in to AWS XRay, so having those would make that super simple.