Map Plus/Minus to Intuitive Zoom Controls

[rsthornton]

Description

The keyboard zoom mapping in the Leptos key handler is inverted. Update the mapping so plus/equal zooms in and minus/underscore zooms out. Ensure the Controls menu text matches.

File Pointers

• Key handler: bert/bert/src/leptos_app/mod.rs (container around the Bevy canvas; id="bevy-container", tabindex="0")
• Controls menu text: bert/bert/src/leptos_app/components/controls_menu.rs

Tasks

• Update keydown handler mapping:
  • - or _ → send ZoomOut
  • = or + → send ZoomIn
• Also handle numpad keys: NumpadSubtract → ZoomOut, NumpadAdd → ZoomIn
• Keep ev.prevent_default() so browser page zoom doesn’t trigger when the canvas is focused
• Update labels in controls_menu.rs to reflect the same mapping
• Verify no regressions to mouse wheel zoom or theme toggle

Acceptance Criteria

• Pressing -/_ zooms OUT; pressing =/+ zooms IN (including numpad +/-)
• Controls menu labels: Zoom Out = - key; Zoom In = = key
• Behavior validated on Chrome, Firefox, and Safari
• No changes to existing mouse wheel zoom logic or Ctrl/Option+B theme toggle
• When the canvas container is focused, browser page zoom is prevented for these keys

Manual Test Checklist

• Click on the canvas area to focus (container must have tabindex="0")
• Press - repeatedly: the view zooms out smoothly
• Press = repeatedly: the view zooms in smoothly
• Press numpad - and +: behavior matches above
• Open Controls menu and verify labels match behavior
• Use mouse wheel + modifier and confirm unchanged behavior
• With canvas focused, verify the browser does not page‑zoom when using =/+ or -/_

[rsthornton]

Hello, I just pushed a few updates which should make the contributor/developer guides available at the bottom of the readme. Try this and let me know if you have any questions or problems. https://github.com/halcyonic-systems/bert/blob/main/CONTRIBUTING.md

…

On Wed, Sep 3, 2025 at 3:42 PM Aaravthk ***@***.***> wrote: *Aaravthk* left a comment (halcyonic-systems/bert#3) <#3 (comment)> Hey, I'd like to take up this issue, but I can't find the contributing guide. Can you help me with wall the contributing guidelines are? Thanks — Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGFBKNM5XFXCQLONLGGAJD3Q5ABJAVCNFSM6AAAAACFQUP2N6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENJQGUZTONZTG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Shingai Thornton

[Aaravthk]

Hey, I've solved this issue and raised a pull request. Can you please review it?

Thanks

[suhas-sensei]

hey @rsthornton does this repo fund contributions through the merit systems platform?

[rsthornton]

hey @suhas-sensei, i haven't made any distributions yet but I will be funding contributions via merit on a regular basis starting in early 2026.

[suhas-sensei]

@rsthornton thanks sir for the heads up, i will be looking into these issues then. Expect some PRs :)