Skip to content
This repository was archived by the owner on Jan 26, 2018. It is now read-only.
This repository was archived by the owner on Jan 26, 2018. It is now read-only.

Cleanup: remove zipUrl and vestigial isGoogleApi references #77

@geigerj

Description

@geigerj

Currently, there is an option to download protos from github into a zip file; this is unused by artman, and the use case is superseded by the artman remote mode. Let's remove the flag and all related code in the library. This will require refactoring the tests, which mostly rely on the zip file case.

In addition, #74 removed the isGoogleApi flag, but there are continued references to this variable in api_repo.js because it is automatically set when packman is running with zip file input or when it is building common protos. After this issue is closed, the former case is no longer supported, and the latter case can be refactored.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions