Skip to content
This repository was archived by the owner on Mar 8, 2023. It is now read-only.
This repository was archived by the owner on Mar 8, 2023. It is now read-only.

Proposals don't support empty commit links #96

@evonide

Description

@evonide

Describe the bug
Creating a proposal with an empty commit link currently leads to the application error: "Please specify a valid commit link".

To Reproduce
Steps to reproduce the behavior:

  1. Go to any vulnerability entry (with an existing commit link).
  2. Propose changes and leave commit link empty or remove it.
  3. Submit changes.

Expected behavior
Commit links are supposed to be optional.

Additional context
data/models/vulnerability.py has a commit_link.setter. Using just a return for empty strings leads to an error in the diff algorithm in data/models/base.py where it would not recognize that the commit link has been changed and reject the proposal.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions