From e1ab4ae73a69acbecb80c89f70efab6b98685fc7 Mon Sep 17 00:00:00 2001 From: kurilova Date: Wed, 4 Dec 2024 11:38:24 +0000 Subject: [PATCH 1/2] Migrate code to new angular features: signals and injection --- modules/ui/src/app/app-routing.module.ts | 31 ++-- modules/ui/src/app/app.component.html | 1 - modules/ui/src/app/app.component.spec.ts | 108 ++++++++----- modules/ui/src/app/app.component.ts | 143 ++++++++++++------ modules/ui/src/app/app.module.ts | 113 -------------- modules/ui/src/app/app.store.ts | 16 +- .../app/components/bypass/bypass.component.ts | 7 +- .../components/callout/callout.component.ts | 2 +- .../device-item/device-item.component.spec.ts | 2 - .../device-item/device-item.component.ts | 2 +- .../device-tests/device-tests.component.ts | 2 +- .../download-report-pdf.component.ts | 2 +- .../download-report-zip.component.spec.ts | 1 - .../download-report-zip.component.ts | 14 +- .../download-report.component.ts | 2 +- .../download-zip-modal.component.spec.ts | 1 - .../download-zip-modal.component.ts | 26 ++-- .../dynamic-form.component.spec.ts | 11 +- .../dynamic-form/dynamic-form.component.ts | 14 +- .../escapable-dialog.component.ts | 10 +- .../program-type-icon.component.ts | 2 +- .../report-action/report-action.component.ts | 12 +- .../shutdown-app-modal.component.ts | 18 ++- .../shutdown-app/shutdown-app.component.ts | 13 +- .../simple-dialog/simple-dialog.component.ts | 25 ++- .../snack-bar/snack-bar.component.ts | 5 +- .../components/spinner/spinner.component.ts | 8 +- .../stepper/stepper.component.spec.ts | 12 +- .../components/stepper/stepper.component.ts | 1 - .../testing-complete.component.spec.ts | 1 - .../testing-complete.component.ts | 11 +- .../consent-dialog.component.ts | 13 +- .../components/version/version.component.ts | 11 +- .../src/app/components/wifi/wifi.component.ts | 2 +- .../interceptors/error-handler.interceptor.ts | 13 +- .../src/app/interceptors/error.interceptor.ts | 5 +- .../app/interceptors/loading.interceptor.ts | 10 +- .../certificate-item.component.ts | 2 +- .../certificate-upload-button.component.ts | 2 +- .../certificates/certificates.component.ts | 19 ++- .../pages/certificates/certificates.store.ts | 12 +- ...evice-qualification-from.component.spec.ts | 2 +- .../device-qualification-from.component.ts | 37 ++--- .../pages/devices/devices-routing.module.ts | 33 ---- .../pages/devices/devices.component.spec.ts | 6 +- .../app/pages/devices/devices.component.ts | 45 ++++-- .../src/app/pages/devices/devices.module.ts | 59 -------- .../ui/src/app/pages/devices/devices.store.ts | 10 +- .../delete-report/delete-report.component.ts | 12 +- .../filter-chips/filter-chips.component.ts | 2 +- .../filter-dialog.component.spec.ts | 4 +- .../filter-dialog/filter-dialog.component.ts | 47 +++--- .../filter-header/filter-header.component.ts | 2 +- .../pages/reports/reports-routing.module.ts | 26 ---- .../pages/reports/reports.component.spec.ts | 10 +- .../app/pages/reports/reports.component.ts | 62 +++++--- .../src/app/pages/reports/reports.module.ts | 51 ------- .../ui/src/app/pages/reports/reports.store.ts | 12 +- .../success-dialog.component.ts | 20 ++- .../profile-form/profile-form.component.ts | 19 +-- .../profile-item.component.spec.ts | 4 +- .../profile-item/profile-item.component.ts | 24 +-- .../risk-assessment-routing.module.ts | 26 ---- .../risk-assessment.component.spec.ts | 9 +- .../risk-assessment.component.ts | 47 +++++- .../risk-assessment/risk-assessment.module.ts | 57 ------- .../risk-assessment/risk-assessment.store.ts | 12 +- .../settings-dropdown.component.spec.ts | 6 +- .../settings-dropdown.component.ts | 2 +- .../pages/settings/settings.component.spec.ts | 23 ++- .../app/pages/settings/settings.component.ts | 69 +++++++-- .../src/app/pages/settings/settings.store.ts | 10 +- .../download-options.component.ts | 10 +- .../testrun-initiate-form.component.spec.ts | 4 +- .../testrun-initiate-form.component.ts | 66 ++++++-- .../testrun-status-card.component.spec.ts | 6 +- .../testrun-status-card.component.ts | 23 ++- .../testrun-table.component.html | 4 +- .../testrun-table.component.spec.ts | 11 +- .../testrun-table/testrun-table.component.ts | 48 ++++-- .../pages/testrun/testrun-routing.module.ts | 26 ---- .../pages/testrun/testrun.component.spec.ts | 58 +++++-- .../app/pages/testrun/testrun.component.ts | 47 ++++-- .../src/app/pages/testrun/testrun.module.ts | 67 -------- .../ui/src/app/pages/testrun/testrun.store.ts | 12 +- modules/ui/src/app/services/loader.service.ts | 11 +- .../src/app/services/notification.service.ts | 14 +- .../services/test-run-mqtt.service.spec.ts | 4 +- .../src/app/services/test-run-mqtt.service.ts | 8 +- .../ui/src/app/services/test-run.service.ts | 6 +- modules/ui/src/app/store/effects.ts | 16 +- modules/ui/src/main.ts | 52 ++++++- 92 files changed, 949 insertions(+), 997 deletions(-) delete mode 100644 modules/ui/src/app/app.module.ts delete mode 100644 modules/ui/src/app/pages/devices/devices-routing.module.ts delete mode 100644 modules/ui/src/app/pages/devices/devices.module.ts delete mode 100644 modules/ui/src/app/pages/reports/reports-routing.module.ts delete mode 100644 modules/ui/src/app/pages/reports/reports.module.ts delete mode 100644 modules/ui/src/app/pages/risk-assessment/risk-assessment-routing.module.ts delete mode 100644 modules/ui/src/app/pages/risk-assessment/risk-assessment.module.ts delete mode 100644 modules/ui/src/app/pages/testrun/testrun-routing.module.ts delete mode 100644 modules/ui/src/app/pages/testrun/testrun.module.ts diff --git a/modules/ui/src/app/app-routing.module.ts b/modules/ui/src/app/app-routing.module.ts index a9864fe63..fd77640cf 100644 --- a/modules/ui/src/app/app-routing.module.ts +++ b/modules/ui/src/app/app-routing.module.ts @@ -13,34 +13,33 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import { NgModule } from '@angular/core'; -import { RouterModule, Routes } from '@angular/router'; +import { Routes } from '@angular/router'; +import { ReportsComponent } from './pages/reports/reports.component'; +import { DevicesComponent } from './pages/devices/devices.component'; +import { CanDeactivateGuard } from './guards/can-deactivate.guard'; +import { TestrunComponent } from './pages/testrun/testrun.component'; +import { RiskAssessmentComponent } from './pages/risk-assessment/risk-assessment.component'; -const routes: Routes = [ +export const routes: Routes = [ { path: 'testing', - loadChildren: () => - import('./pages/testrun/testrun.module').then(m => m.TestrunModule), + component: TestrunComponent, title: 'Testrun', }, { path: 'devices', - loadChildren: () => - import('./pages/devices/devices.module').then(m => m.DevicesModule), + component: DevicesComponent, + canDeactivate: [CanDeactivateGuard], title: 'Testrun - Devices', }, { path: 'reports', - loadChildren: () => - import('./pages/reports/reports.module').then(m => m.ReportsModule), + component: ReportsComponent, title: 'Testrun - Reports', }, { path: 'risk-assessment', - loadChildren: () => - import('./pages/risk-assessment/risk-assessment.module').then( - m => m.RiskAssessmentModule - ), + component: RiskAssessmentComponent, title: 'Testrun - Risk Assessment', }, { @@ -49,9 +48,3 @@ const routes: Routes = [ pathMatch: 'full', }, ]; - -@NgModule({ - imports: [RouterModule.forRoot(routes, { useHash: true })], - exports: [RouterModule], -}) -export class AppRoutingModule {} diff --git a/modules/ui/src/app/app.component.html b/modules/ui/src/app/app.component.html index 5da13edc6..cff15804e 100644 --- a/modules/ui/src/app/app.component.html +++ b/modules/ui/src/app/app.component.html @@ -83,7 +83,6 @@

Testrun