- |
- Result
-
-
- |
+ sortActionDescription="Sort by result"
+ headerText="Result"
+ [filterName]="FilterName.Results"
+ [filterOpened]="vm.filterOpened"
+ [activeFilter]="vm.activeFilter"
+ (emitOpenFilter)="openFilter($event)">
+
Reports
-
-
-
-
diff --git a/modules/ui/src/app/pages/reports/reports.component.scss b/modules/ui/src/app/pages/reports/reports.component.scss
index b502c7768..ce158fcef 100644
--- a/modules/ui/src/app/pages/reports/reports.component.scss
+++ b/modules/ui/src/app/pages/reports/reports.component.scss
@@ -76,7 +76,7 @@
justify-content: center;
align-items: center;
flex-shrink: 0;
- margin: 0 2px 0 8px;
+ margin: 0 2px 0 12px;
padding: 0;
border: none;
background: colors.$white;
diff --git a/modules/ui/src/app/pages/reports/reports.component.spec.ts b/modules/ui/src/app/pages/reports/reports.component.spec.ts
index 4bcf2ebf3..b829e1cb3 100644
--- a/modules/ui/src/app/pages/reports/reports.component.spec.ts
+++ b/modules/ui/src/app/pages/reports/reports.component.spec.ts
@@ -181,7 +181,11 @@ describe('ReportsComponent', () => {
} as MatDialogRef );
fixture.detectChanges();
- component.openFilter(event, '', false);
+ component.openFilter({
+ event,
+ filter: '',
+ filterOpened: false,
+ });
expect(openSpy).toHaveBeenCalled();
expect(openSpy).toHaveBeenCalledWith(FilterDialogComponent, {
@@ -225,10 +229,26 @@ describe('ReportsComponent', () => {
} as MatDialogRef);
fixture.detectChanges();
- component.openFilter(event, FilterName.Started, false);
- component.openFilter(event, FilterName.Results, false);
- component.openFilter(event, FilterName.DeviceFirmware, false);
- component.openFilter(event, FilterName.DeviceInfo, false);
+ component.openFilter({
+ event,
+ filter: FilterName.Started,
+ filterOpened: false,
+ });
+ component.openFilter({
+ event,
+ filter: FilterName.Results,
+ filterOpened: false,
+ });
+ component.openFilter({
+ event,
+ filter: FilterName.DeviceFirmware,
+ filterOpened: false,
+ });
+ component.openFilter({
+ event,
+ filter: FilterName.DeviceInfo,
+ filterOpened: false,
+ });
expect(mockReportsStore.setFilteredValuesResults).toHaveBeenCalledWith(
mockFilterResults
);
diff --git a/modules/ui/src/app/pages/reports/reports.component.ts b/modules/ui/src/app/pages/reports/reports.component.ts
index eb5d90441..a40c2f8f8 100644
--- a/modules/ui/src/app/pages/reports/reports.component.ts
+++ b/modules/ui/src/app/pages/reports/reports.component.ts
@@ -35,6 +35,7 @@ import { MatDialog } from '@angular/material/dialog';
import { tap } from 'rxjs/internal/operators/tap';
import { FilterName, Filters } from '../../model/filters';
import { ReportsStore } from './reports.store';
+import { OpenFilterEvent } from './components/filter-header/filter-header.component';
@Component({
selector: 'app-history',
@@ -77,7 +78,7 @@ export class ReportsComponent implements OnInit, OnDestroy {
return this.testRunService.getResultClass(status);
}
- openFilter(event: Event, filter: string, filterOpened: boolean) {
+ openFilter({ event, filter, filterOpened }: OpenFilterEvent) {
event.stopPropagation();
const target = new ElementRef(event.currentTarget);
diff --git a/modules/ui/src/app/pages/reports/reports.module.ts b/modules/ui/src/app/pages/reports/reports.module.ts
index 18db8a27f..e8ccc0844 100644
--- a/modules/ui/src/app/pages/reports/reports.module.ts
+++ b/modules/ui/src/app/pages/reports/reports.module.ts
@@ -27,6 +27,7 @@ import { FilterChipsComponent } from './components/filter-chips/filter-chips.com
import { DeleteReportComponent } from './components/delete-report/delete-report.component';
import { DownloadReportZipComponent } from '../../components/download-report-zip/download-report-zip.component';
import { DownloadReportPdfComponent } from '../../components/download-report-pdf/download-report-pdf.component';
+import { FilterHeaderComponent } from './components/filter-header/filter-header.component';
@NgModule({
declarations: [ReportsComponent],
@@ -43,6 +44,7 @@ import { DownloadReportPdfComponent } from '../../components/download-report-pdf
DeleteReportComponent,
DownloadReportZipComponent,
DownloadReportPdfComponent,
+ FilterHeaderComponent,
],
providers: [DatePipe],
})
diff --git a/modules/ui/src/styles.scss b/modules/ui/src/styles.scss
index f63c34fcb..0893b13e1 100644
--- a/modules/ui/src/styles.scss
+++ b/modules/ui/src/styles.scss
@@ -423,13 +423,19 @@ button:not(.mat-mdc-button-disabled) {
.mat-sort-header-indicator {
&::before {
content: 'arrow_upward';
- top: -0em;
- line-height: 12px;
+ line-height: 32px;
font-family: #{variables.$font-symbols};
position: absolute;
color: var(--mat-table-header-headline-color);
font-size: 19px;
font-weight: 400;
+ background-color: rgba(68, 71, 70, 0.08);
+ border-radius: 50%;
+ height: 32px;
+ width: 32px;
+ top: -10px;
+ text-align: center;
+ margin-left: 2px;
}
}
}
@@ -439,9 +445,25 @@ button:not(.mat-mdc-button-disabled) {
.mat-sort-header-indicator {
&::before {
content: 'arrow_downward';
- top: -14px;
- line-height: 20px;
+ top: -20px;
}
}
}
}
+
+/*
+
+.mat-mdc-icon-button:hover .mat-mdc-button-persistent-ripple::before {
+ opacity: var(--mat-icon-button-hover-state-layer-opacity, var(--mat-sys-hover-state-layer-opacity));
+}
+ |