Outbound Connections section of report missing

[duncangreene]

Describe the bug
I've seen on a number of reports for devices that the Outbound Connections section is missing, despite sections such as NTP showing evidence of outbound NTP synchronisations.

Expected behavior
The Outbound Connections section is always present. If no Outbound Connections were detected, this should be reported as such (currently this doesn't appear to be the case either).

Error logs
report (42).zip
report (43).zip

Environment (please provide the following information about your setup):

• Version 2.1.1

[jhughesoti]

This issue does not appear to be related specifically to outbound connections as both of those reports indicate that no network capture files were populated with data which may point to an issue with the setup for file access during these runs.

[jboddey]

2 things here: 1, need to investigate why the outbound connections did not appear in these reports. 2, show the outbound connections report on every test attempt - stating that no outbound connections were found.

[jboddey]

I've assigned @hitnik for the 2nd - modifying the outbound connections report.

[jboddey]

Found the issue on this one:
tls_module.py:168 outbound_conns = self._tls_util.get_all_outbound_connections(
device_mac=self._device_mac, capture_files=pcap_files)
This line is incorrectly indented, and will only run if at least one outbound TLS connection is seen.

[KrystsinaT]

The issue has been reported 416694764

[KrystsinaT]

Released in 2.2.1.